From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH 5/5] ISDN-Gigaset: Enclose two expressions for the sizeof operator by parentheses Date: Mon, 26 Sep 2016 18:45:09 +0200 Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> <6d4bbb77-914f-19b8-a1a9-2731d1158612@users.sourceforge.net> <063D6719AE5E284EB5DD2968C1650D6DB0109E63@AcuExch.aculab.com> <1474907003.2238.13.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: LKML , "kernel-janitors@vger.kernel.org" , Julia Lawall To: Joe Perches , David Laight , "gigaset307x-common@lists.sourceforge.net" , "netdev@vger.kernel.org" , Karsten Keil , Paul Bolle Return-path: In-Reply-To: <1474907003.2238.13.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org >>> @@ -53,7 +53,7 @@ void gigaset_dbg_buffer(enum debuglevel level, const unsigned char *msg, >>> { >>> unsigned char outbuf[80]; >>> unsigned char c; >>> - size_t space = sizeof outbuf - 1; >>> + size_t space = sizeof(outbuf - 1); > >> wrong ... >> think that is 7 instead of 79. > > > Well, it's sizeof(pointer) so either 4 or 8, but still, > what Markus proposes here is _wrong_. You are right at this place. > Markus, do you know the script probably has a lower > style conversion defect introduction rate than you do > when doing these mechanical things. Would it be nice if the script "checkpatch.pl" could avoid to point such a false positive out anyhow? > Please use it to verify what you are doing before > submitting more defective patches. Do you expect a resend for this update step so that an other statement in the function "gigaset_initdriver" would eventually be adjusted? Regards, Markus