From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E628C43381 for ; Sun, 3 Mar 2019 08:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E436B20866 for ; Sun, 3 Mar 2019 08:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFnuI/09" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbfCCIuh (ORCPT ); Sun, 3 Mar 2019 03:50:37 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:33496 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfCCIuf (ORCPT ); Sun, 3 Mar 2019 03:50:35 -0500 Received: by mail-pl1-f195.google.com with SMTP id y10so1067730plp.0; Sun, 03 Mar 2019 00:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=itX5jSVSbGCvnjJA3Mjr/J9/iXOCtB68hVwh2te+CtQ=; b=LFnuI/09AcSPEfa6NLUY1j7Y3QvqFfj/9B5xTPvv2Qsx95U/GNHrrUrzh3Bq4hp4Fs oji2WHCPejATlIjzylMW32fP9LLJBl1deMkOLdpZ+rS7W7HLf+tiddjuWAfVMMyNrcQE NxpBf+leKsJJDEObiUUgPoWkDVToieL/nzlj6dsAqXT3CPm74j62nfLrMVe5Y6hUUhUH eXbEMcA90ccNUMYN7jGyc6yF27bMl4UNfZUN3j8NOH6xn6/1gwgSVfpLyO4oJMaBp0Ww liP+3Hfq3CX+8pTcBwAUHrimitGy7HTk4qYfZmgGAz5Yn4aOyJH81IzWFl8ETeVHng1Y fDUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=itX5jSVSbGCvnjJA3Mjr/J9/iXOCtB68hVwh2te+CtQ=; b=lI+Qxde8tuUnpcZZ8x51Z7hDSOrW0p7I/K+ZPEm81qZp96Ad23tZY73jFAOhWzDLxL EHp1tGdi+WWLgQD3MzltIp5IiOhE05GirXMNivOniqBCRVQ7o+JTnJX9TjVWs819q3xy uv5lXZKx93p4NuFGTQ0XzCdXbOtsQs77sFPjoE/e+EwCooEemNThrrizEsLY/D6xsg6p RLwW9l/83EABe+gSlX5QCMTRXUWeIJGSrxro/Nq7Z2CVHlfa4VGeGwUJKBqkal6vsIyn a+7tmlw0ftgV9JWzFL6OJFoUIr3c0n4BuLFtoD+9kb1B62Ix1cDSyg1uuaW6fMFwOHUF yJMQ== X-Gm-Message-State: APjAAAU2WqtlWZPUWOtGbJcmlqrXLU3hFt9WlTp8nSXSnMS2j7Z3uwm9 841Y0u0QXiYeDv40S162ynRipypO X-Google-Smtp-Source: APXvYqw05qOUgvPGExvCXxRU87j60EZMlqk0ComNyST3CBupXotwmMI26KxBeQv2Jp0IE5f/mKdlXw== X-Received: by 2002:a17:902:7614:: with SMTP id k20mr14305810pll.298.1551603034769; Sun, 03 Mar 2019 00:50:34 -0800 (PST) Received: from localhost ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id 1sm7763947pfy.68.2019.03.03.00.50.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 00:50:34 -0800 (PST) From: Xin Long To: network dev , linux-sctp@vger.kernel.org Cc: davem@davemloft.net, Marcelo Ricardo Leitner , Neil Horman Subject: [PATCH net] sctp: call iov_iter_revert() after sending ABORT Date: Sun, 3 Mar 2019 16:50:26 +0800 Message-Id: X-Mailer: git-send-email 2.1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The user msg is also copied to the abort packet when doing SCTP_ABORT in sctp_sendmsg_check_sflags(). When SCTP_SENDALL is set, iov_iter_revert() should have been called for sending abort on the next asoc with copying this msg. Otherwise, memcpy_from_msg() in sctp_make_abort_user() will fail and return error. Fixes: 4910280503f3 ("sctp: add support for snd flag SCTP_SENDALL process in sendmsg") Reported-by: Ying Xu Signed-off-by: Xin Long --- net/sctp/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 65d6d04..a2771b3 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -1866,6 +1866,7 @@ static int sctp_sendmsg_check_sflags(struct sctp_association *asoc, pr_debug("%s: aborting association:%p\n", __func__, asoc); sctp_primitive_ABORT(net, asoc, chunk); + iov_iter_revert(&msg->msg_iter, msg_len); return 0; } -- 2.1.0