From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] tcp: add tcp_release_cb_cond() helper
Date: Thu, 12 Mar 2026 13:26:54 +0100 [thread overview]
Message-ID: <d335d51f-6c42-4d9a-aa3f-4c8a2802ef44@redhat.com> (raw)
In-Reply-To: <20260310124451.2280968-1-edumazet@google.com>
On 3/10/26 1:44 PM, Eric Dumazet wrote:
> Majority of tcp_release_cb() calls do nothing at all.
>
> Provide tcp_release_cb_cond() helper so that release_sock()
> can avoid these calls.
>
> Also hint the compiler thar __release_sock() and wake_up()
I took the liberty of fixing the above typo while applying the patch.
> are rarely called.
For my education: out of sheer ignorance and lack of relevant H/W to
actually measure the thing, I thought that on very high speed link with
big TCP enabled, user-space process and BH processing running on
different CPUs backlog usage would be quite probable?!?
/P
next prev parent reply other threads:[~2026-03-12 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 12:44 [PATCH net-next] tcp: add tcp_release_cb_cond() helper Eric Dumazet
2026-03-11 4:20 ` Kuniyuki Iwashima
2026-03-12 12:26 ` Paolo Abeni [this message]
2026-03-12 12:33 ` Eric Dumazet
2026-03-12 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d335d51f-6c42-4d9a-aa3f-4c8a2802ef44@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox