netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] selftests: net: really check for bg process completion
Date: Tue, 5 Nov 2024 14:40:28 -0700	[thread overview]
Message-ID: <d3595e03-acbb-4a93-84cc-0dabe5259742@kernel.org> (raw)
In-Reply-To: <0e6f213811f8e93a235307e683af8225cc6277ae.1730828007.git.pabeni@redhat.com>

On 11/5/24 11:23 AM, Paolo Abeni wrote:
> A recent refactor transformed the check for process completion
> in a true statement, due to a typo.
> 
> As a result, the relevant test-case is unable to catch the
> regression it was supposed to detect.
> 
> Restore the correct condition.
> 
> Fixes: 691bb4e49c98 ("selftests: net: avoid just another constant wait")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>


  reply	other threads:[~2024-11-05 21:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 18:23 [PATCH v2 net-next 0/2] ipv6: fix hangup on device removal Paolo Abeni
2024-11-05 18:23 ` [PATCH v2 net-next 1/2] ipv6: release nexthop " Paolo Abeni
2024-11-05 18:26   ` Eric Dumazet
2024-11-05 21:40   ` David Ahern
2024-11-06  9:11     ` Paolo Abeni
2024-11-05 18:23 ` [PATCH v2 net-next 2/2] selftests: net: really check for bg process completion Paolo Abeni
2024-11-05 21:40   ` David Ahern [this message]
2024-11-07  2:00 ` [PATCH v2 net-next 0/2] ipv6: fix hangup on device removal patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3595e03-acbb-4a93-84cc-0dabe5259742@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).