From: Pavel Skripkin <paskripkin@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: davem@davemloft.net, kuba@kernel.org, tanghui20@huawei.com,
andrew@lunn.ch, oneukum@suse.com, arnd@arndb.de,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+003c0a286b9af5412510@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: mcs7830: handle usb read errors properly
Date: Fri, 7 Jan 2022 13:18:27 +0300 [thread overview]
Message-ID: <d36007da-58a3-da8d-dcad-e41b1c5cffa8@gmail.com> (raw)
In-Reply-To: <YdgQuavHA/T8tlHi@kroah.com>
Hi Greg,
On 1/7/22 13:06, Greg KH wrote:
>
> We have a usb core function that handles these "short reads are an
> error" issue. Perhaps usbnet_read_cmd() should be converted to use it
> instead?
>
I thought about it. I am not sure, that there are no callers, that
expect various length data. I remember, that I met such problem in atusb
driver, but it uses plain usb API.
I believe, we can provide new usbnet API, that will use
usb_control_msg_{recv,send} and сarefully convert drivers to use it.
When there won't be any callers of the old one we can just rename it.
I might be missing something about usbnet, so, please, correct me if I
am wrong here :)
With regards,
Pavel Skripkin
next prev parent reply other threads:[~2022-01-07 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 22:57 [PATCH] net: mcs7830: handle usb read errors properly Pavel Skripkin
2022-01-07 2:31 ` Arnd Bergmann
2022-01-07 10:06 ` Greg KH
2022-01-07 10:18 ` Pavel Skripkin [this message]
2022-01-10 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d36007da-58a3-da8d-dcad-e41b1c5cffa8@gmail.com \
--to=paskripkin@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=syzbot+003c0a286b9af5412510@syzkaller.appspotmail.com \
--cc=tanghui20@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).