From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: acsjakub@amazon.de, liuhangbin@gmail.com, kees@kernel.org,
horms@kernel.org, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, fmaurer@redhat.com,
Luka Gejak <luka.gejak@linux.dev>
Subject: Re: [PATCH net-next] net: hsr: emit notification for PRP slave2 changed hw addr on port deletion
Date: Tue, 7 Apr 2026 15:37:12 +0200 [thread overview]
Message-ID: <d38ea95d-98d2-42ab-aea0-3099ab05082d@suse.de> (raw)
In-Reply-To: <756852a4-b589-4eeb-81bf-963fa2e71821@redhat.com>
On 4/7/26 3:29 PM, Paolo Abeni wrote:
> On 4/3/26 2:39 PM, Fernando Fernandez Mancera wrote:
>> On PRP protocol, when deleting the port the MAC address change
>> notification was missing. In addition to that, make sure to only perform
>> the MAC address change on slave2 deletion and PRP protocol as the
>> operation isn't necessary for HSR nor slave1.
>>
>> Note that the eth_hw_addr_set() is correct on PRP context as the slaves
>> are either in promiscuous mode or forward offload enabled.
>>
>> Fixes: b65999e7238e ("net: hsr: sync hw addr of slave2 according to slave1 hw addr on PRP")
>> Reported-by: Luka Gejak <luka.gejak@linux.dev>
>> Closes: https://lore.kernel.org/netdev/DHFCZEM93FTT.1RWFBIE32K7OT@linux.dev/
>> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
>> ---
>> Note: routed through net-next tree as the next net tree as rc6 batch is
>> already out and I do not think this is worth to be included in a last
>> call batch. Anyway, if maintainer thinks it is, feel free to apply it to
>> net tree.
>
> The general guidance is to avoid fixes tag for net-next patches that do
> not fix net-next specific code. In this case I assume you want the patch
> landing into stable right?
>
Hi Paolo,
Noted. I wanted to reduce the number of patches on net tree given we are
at the end of the development cycle. To be honest, the stable backport
isn't that important here, this is a trivial fix that I doubt it was
breaking anyone.
Maybe drop Fixes tag and get it into net-next then? Fine for me anyway,
I trust your judgement on this.
Thanks,
Fernando.
> I think a net target would be better, please LMK.
>
> /P
>
next prev parent reply other threads:[~2026-04-07 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 12:39 [PATCH net-next] net: hsr: emit notification for PRP slave2 changed hw addr on port deletion Fernando Fernandez Mancera
2026-04-07 13:29 ` Paolo Abeni
2026-04-07 13:37 ` Fernando Fernandez Mancera [this message]
2026-04-07 15:08 ` Paolo Abeni
2026-04-07 14:08 ` Felix Maurer
2026-04-07 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d38ea95d-98d2-42ab-aea0-3099ab05082d@suse.de \
--to=fmancera@suse.de \
--cc=acsjakub@amazon.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fmaurer@redhat.com \
--cc=horms@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=luka.gejak@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox