From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEEDE3B9DA9 for ; Tue, 7 Apr 2026 13:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775569045; cv=none; b=kIY8plkgyV/pWyzait1YoxlCWiJW9Xa+yA0EjFMCvHOTyX44/YWYQhMn74WLWvY4xWignaxjvm/i3Np7ZJ3YNuSDQ13BOQFEZGxdmRTCjXu4+9534GMnNBa6qVDF6IITMxREkSIXM7yIe4XRFhgcFdzNrjljqn2ZxdEsR6jUwDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775569045; c=relaxed/simple; bh=KN/dorCqDpCgbJbv9MByARZpWybjjuffk5SEcyCBF2k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BkWHSS+TjNLmvAoFw0wVAhOptM1J3P6Dy1dEpj5D51WwrY7OcKSgupbe2roOPKvbrBqOUHox73xomtt3Bh7bJDa9RZfdDQs1cLNkyMVIDySwgsKHmpKQTenn7iWI631X5WCDOLpoKFlsn9gz2CrKYX4Ztv62KOai1YIJjZ1uLZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=twrss0rC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=nCP1aKHz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=twrss0rC; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=nCP1aKHz; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="twrss0rC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="nCP1aKHz"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="twrss0rC"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="nCP1aKHz" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0FE365BD6C; Tue, 7 Apr 2026 13:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baED2cWw2KCUCxFd3JykN/toCiAn2SshVfG1NPWtzrc=; b=twrss0rCX0RLfLLtVqhiBZUFsnHLJuk1WQAYs1LUUSSnN/c063CpEl6SVx/Mwbt/O0zIq6 Rnmt1c+v/6+LBLO3reYWfWOmrq4SQB4xYHLhwtPNGv8fQoud/o1BAXG1yhbiTInUl0Vgav gNjRDgmZk+thr05jnTiLSBKWSoKmfb0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baED2cWw2KCUCxFd3JykN/toCiAn2SshVfG1NPWtzrc=; b=nCP1aKHzNNSg/tsGp4InW/3JdkYq7NYEjvdp0Gwze3HNXa9DadWZIhftnTHpjmKjqkKKSK DiTHtgzK557z7tBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=twrss0rC; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nCP1aKHz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775569042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baED2cWw2KCUCxFd3JykN/toCiAn2SshVfG1NPWtzrc=; b=twrss0rCX0RLfLLtVqhiBZUFsnHLJuk1WQAYs1LUUSSnN/c063CpEl6SVx/Mwbt/O0zIq6 Rnmt1c+v/6+LBLO3reYWfWOmrq4SQB4xYHLhwtPNGv8fQoud/o1BAXG1yhbiTInUl0Vgav gNjRDgmZk+thr05jnTiLSBKWSoKmfb0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775569042; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baED2cWw2KCUCxFd3JykN/toCiAn2SshVfG1NPWtzrc=; b=nCP1aKHzNNSg/tsGp4InW/3JdkYq7NYEjvdp0Gwze3HNXa9DadWZIhftnTHpjmKjqkKKSK DiTHtgzK557z7tBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69D1B4A0B0; Tue, 7 Apr 2026 13:37:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cGnNFpEI1WkIWwAAD6G6ig (envelope-from ); Tue, 07 Apr 2026 13:37:21 +0000 Message-ID: Date: Tue, 7 Apr 2026 15:37:12 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: hsr: emit notification for PRP slave2 changed hw addr on port deletion To: Paolo Abeni , netdev@vger.kernel.org Cc: acsjakub@amazon.de, liuhangbin@gmail.com, kees@kernel.org, horms@kernel.org, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, fmaurer@redhat.com, Luka Gejak References: <20260403123928.4249-2-fmancera@suse.de> <756852a4-b589-4eeb-81bf-963fa2e71821@redhat.com> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <756852a4-b589-4eeb-81bf-963fa2e71821@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[amazon.de,gmail.com,kernel.org,google.com,davemloft.net,redhat.com,linux.dev]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[11]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: 0FE365BD6C X-Spam-Flag: NO X-Spam-Score: -4.51 X-Spam-Level: On 4/7/26 3:29 PM, Paolo Abeni wrote: > On 4/3/26 2:39 PM, Fernando Fernandez Mancera wrote: >> On PRP protocol, when deleting the port the MAC address change >> notification was missing. In addition to that, make sure to only perform >> the MAC address change on slave2 deletion and PRP protocol as the >> operation isn't necessary for HSR nor slave1. >> >> Note that the eth_hw_addr_set() is correct on PRP context as the slaves >> are either in promiscuous mode or forward offload enabled. >> >> Fixes: b65999e7238e ("net: hsr: sync hw addr of slave2 according to slave1 hw addr on PRP") >> Reported-by: Luka Gejak >> Closes: https://lore.kernel.org/netdev/DHFCZEM93FTT.1RWFBIE32K7OT@linux.dev/ >> Signed-off-by: Fernando Fernandez Mancera >> --- >> Note: routed through net-next tree as the next net tree as rc6 batch is >> already out and I do not think this is worth to be included in a last >> call batch. Anyway, if maintainer thinks it is, feel free to apply it to >> net tree. > > The general guidance is to avoid fixes tag for net-next patches that do > not fix net-next specific code. In this case I assume you want the patch > landing into stable right? > Hi Paolo, Noted. I wanted to reduce the number of patches on net tree given we are at the end of the development cycle. To be honest, the stable backport isn't that important here, this is a trivial fix that I doubt it was breaking anyone. Maybe drop Fixes tag and get it into net-next then? Fine for me anyway, I trust your judgement on this. Thanks, Fernando. > I think a net target would be better, please LMK. > > /P >