From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.224.132 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793647610; b=pIBOWTlx9WNXZb4p92vyHavb0LjO1k7AsEhvLsyFjXCyLsxqAVWybRmOfqv1GKQTiEkP fJFZw2V5AqqkdXsBVWkgiYC312Rgiy1xgL1XrZsdgd6FWfsNBPPijYkt8yz567Z2lcZI/ QWOhpwbjQEvYXL4eV5/cRch50ZwVl6vp5t7ew6hC1yNzW0M99zHsm8qMP0NtBYcflSxBL Yyrr5kkPE7tun/cpI6ZusxJ+IFTwtdVvflLSOiWWwPEgzqrJ+RjVqIPdQTDphs7fUeiat J/na7PZIv3EcU4znAV9gjHdJT+jyUlxSaBNhWvOOX5glqqw8G7nacysEaB/D0LBkWWA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793647610; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=GGgFPYYG6oWLUvP1KotHDJ9Xw83iP8ii3ww9kM3hKP0=; b=Jvtkh+LE1/+M9eNWpZOmr+x/mhkVk7dDBWGSRl4mzIdOwbIvaJLu/qfwhKKYgSfiQ+r1 scQXeumrsFH6tljzh1DnQ3tDnsPCYJK0ZojjQ3ndxeuExurG8zVkk5qQ6JF0IcnKLszI6 TS9FAF1fshcqz6gtR4RdKYzo9igbrWvv4ltAjzLVA/HKUWtQAwuKYFMXXoJhB9Ua9/X9g H2+wVRkBfEYOQtvlOr6mx7sa9e0xVCnzRGg1Ai/zud5mOsQud6fpG/J9mzRRfDEC4Mvsl Gwnb4eQ/uKq7aQgMiMGDB6YwEUpK0yQyGpikg3MCdVlCNg9wWK7bBx8nMFs1N7jJiGg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ji5BHOzQ; arc=none smtp.remote-ip=74.125.224.132 Received: from mail-yx2-f4.google.com (mail-yx2-f4.google.com [74.125.224.132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7BDC606A329 for ; Mon, 2 Nov 2026 19:26:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D7BDC606A329 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=ji5BHOzQ Received: by mail-yx2-f4.google.com with SMTP id 956f58d0204a3-679a254a724so1824383d50.0 for ; Mon, 02 Nov 2026 11:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793647609; x=1794252409; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GGgFPYYG6oWLUvP1KotHDJ9Xw83iP8ii3ww9kM3hKP0=; b=ji5BHOzQ1RzwPyqsk2s8cHAViYOWD/O+3bZQY/tAGPh6iajASEYoYfopk4UXn09Dvp a8Y3e2wrg8IO3piRB36K67BsnG7u0nhbSW+8Ju9C2+l8e4PSWFRKG3DHntj+sT/fctga 4R6gRl67e2TJBXI2nqrqp02Uj3sBQ8yzPwhNpwHIW8R2V6i2xrLJ0gU3vj79VkfBnMpJ 5UoLOdz12VNFiwzSkpjsJT5tWJh95TTv8UHajaoTTo6ciV2sUFHKn09peiEAe3KCubYa gmdR7/rtDT7RHk67imJuw2/NIFZXKHl0hTZH0cbZIjhp8KOT1bA+l8VGOwaPX59+N1dJ pdZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793647609; x=1794252409; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GGgFPYYG6oWLUvP1KotHDJ9Xw83iP8ii3ww9kM3hKP0=; b=mcdeYgV8vb3Mbc2jDc+DQ3TZ4dMAjM/lnC1ldEULLyRH19QlMVXl0dugVCWijDetVV x+hXdwUlmvwv1SdWEb6bD1NpQyqlqzPoJkpSPRPTnDELagOQXrGHsY2PVC42y49uX82S Meznwmc382gJMDOWZ/wVIZ1BaMRX/GmvI1V6DBFectMOJse8dYa1TSbG8wP9KGUjPkXq SsnvEA6WjqLi4TWsn5yVzl/Gq7TzxG+bKLrp/E5Ig6+f5/P6JO3xStkx4JwUhdkybpqB ShSoH9QldhZm0EOUZNylkXbGM+2O6cv3tT98eDcx4KZtk6Tp1Ui7BnA12W/uZknYXnC5 +w5Q== X-Forwarded-Encrypted: i=1; AKwUvBwQ9BZjMqt4ql6vcWky5pxmooLpI1ZxgaSDZlFGSXmseM2PDqd9J+qCK+JepAgy+Y+mCTX/Dnc=@vger.kernel.org X-Gm-Message-State: APuU4Z9+Mb6xp6K3TIwL65Brhdh8FO85/S4Rf6O7ozEXxCojPWyw6iGE sBrJSUSryQ5qk97bzEEFVZHJi7VXONut0q6eCbmcLOoibbjknFFy+DmS X-Gm-Gg: AYBFou1e4Ts6DE5uNo0JPGu0EsqjuX0wwBQnNAcqSZIY6R5t7IR2s5PTDGetUvyY8yR bBEK2DhRijaDzcadHHecGhMx6NrU3VTctVD+JLlIgyHEcF+LK//mHRimCj3cnYHQPxz0CUMcbGW q6MnyD/6fpm/5FHMvdcX/4Hbj8DvcoQSelKLvmBaEaptlYEHCZoMwb1NVaaHwde/dYy6oJXfuxj 4JFSXc3AOVBDLBVgW104bBVhx5ZeCDHgnC8sGVRBo/nukAtt26UqvA65tv7pI+9Pnp+FFdrJqf6 zDoCGLoNl4Mx58PwOT6cDc+99Vef0O4eYpyWRHcEC/PApKdF6OMbhkIa7+1q23AVpU9jUjFvzE/ D59Mq9RB2q+eMC4xbOMI0dFbv88DY6XqZNYeKP7bD5IEyK/1/3il+oRMXOafc+7uiOG/DXaUL2n 3pVwzVVpJmlJAzaMsLLMPB6CrvJLsRqLsg/OPIut48cM4TQo57Xs47eHelsgWgJJnH743lcj382 LxLa5sFIKUbkJPEYdkJLXINcUbxR7Ox+hAAvE0/L64TRO+Ry2Jl8FIraSdyL0GRIyV5PtjgVrIn Culo4HfMiwCIpM5z7YGiVrXaFLb8FylpUF8= X-Received: by 2002:a53:d148:0:b0:679:93bd:85ee with SMTP id 956f58d0204a3-67ba4ffc1a6mr6007860d50.39.1793647608751; Mon, 02 Nov 2026 11:26:48 -0800 (PST) Received: from [10.0.0.48] ([71.69.222.122]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-67baf3700b8sm5719489d50.23.2026.11.02.11.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Nov 2026 11:26:48 -0800 (PST) Message-ID: Date: Mon, 2 Nov 2026 14:26:47 -0500 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v4 0/5] tls: perform TLS 1.3 KeyUpdate in the kernel To: Chuck Lever , Martin Belanger Cc: John Fastabend , Jakub Kicinski , Sabrina Dubroca , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , Shuah Khan , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, Hannes Reinecke , kernel-tls-handshake@lists.linux.dev, linux-nvme@lists.infradead.org, Alistair Francis References: <20261102-keyupdate-rfc-v4-0-f17419972b9f@gmail.com> <785aa669-8229-4909-ad33-66f0824687bd@slotpi15m67> Content-Language: en-US From: Martin Belanger In-Reply-To: <785aa669-8229-4909-ad33-66f0824687bd@slotpi15m67> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/26 13:24, Chuck Lever wrote: > On Mon, 02 Nov 2026 11:57:57 -0500, Martin Belanger wrote: >> The matching tlshd change for ktls-utils is a small patch to be >> submitted at a later time if this series is accepted. > > Recognizing that there may be further API changes, for the series: > > Reviewed-by: Chuck Lever > > I don't expect any changes for the sunrpc consumers will be necessary. > For tlshd, as far as I can tell the whole change is: > > - In tlshd_start_tls_handshake(), register a callback with > gnutls_handshake_set_secret_function() before the gnutls_handshake() > loop, as quic.c already does. We rely on SSLKEYLOGFILE to decrypt > NFS traffic in Wireshark, so that needs to continue to work. > > - In tlshd_initialize_ktls(), after the existing TLS_TX and TLS_RX > install succeeds and only for a TLS 1.3 session, set > TLS_TX_TRAFFIC_SECRET with the write secret, then > TLS_RX_TRAFFIC_SECRET with the read secret. > > - A configure.ac check for TLS_TX_TRAFFIC_SECRET in the installed > uapi header, so the build works against older kernels. > > I assume you plan to send tlshd patches, but let me know if instead > you'd like the ktls-handshake folks to take care of this. > > Thanks for the review. Yes, I will send the tlshd patches. I have a prototype, but it uses gnutls_session_set_keylog_function(). That replaces the default SSLKEYLOGFILE writer, so I will switch it to gnutls_handshake_set_secret_function() as quic.c does, and add the configure.ac check. I will post it to ktls-utils once the kernel uAPI is settled. Martin