From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB72BC4360F for ; Fri, 5 Apr 2019 11:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF3F0217D4 for ; Fri, 5 Apr 2019 11:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dYilnntQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730809AbfDELAZ (ORCPT ); Fri, 5 Apr 2019 07:00:25 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:35539 "EHLO mail-wr1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730546AbfDELAZ (ORCPT ); Fri, 5 Apr 2019 07:00:25 -0400 Received: by mail-wr1-f45.google.com with SMTP id w1so7475242wrp.2 for ; Fri, 05 Apr 2019 04:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hszb6PKzgQoh0hs4CIGCIX4EL7DiNlevXSifFNtAYM0=; b=dYilnntQzc+STORsx2/jmkZvZZQ3/p8MY3GmPXXQZco2XHQpHzSLCDj/weakogYFXA 361FLjmuBB4E1IqxIpOZutMDjXa8zLVFcp3uG9evaDjDMS0HTLk8TWHUlOceYLSMV6dy QjH/JcI6zShTgXm1x//uS6gBZ05XbfOIIv13BekawcyAU5offw5kwZTgu6Zi/CtGKQH1 xPhQ0TQ4lc4PQFqhhjS4ZEUXJygnFZN6bfffFSffnD5v2s0GF0b6MUKHe4WRaagvYtXd GMSVvFxN2oTFnEx7WFaokVVS9Vt7QtKlJONFnCMFbAfvPPc9ZHcD6LD7Zhxl+GmpbvQh 0rCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hszb6PKzgQoh0hs4CIGCIX4EL7DiNlevXSifFNtAYM0=; b=Ju1AsthMTuq4Qlrd6Llk8FrGvtFapoxx6vx6MvrOGhsDH+59AbpH65wMLAwzMEQ6oy sC89OJBvZRm0WtOtph+3SRigZ6nkReDsV19gscnXZ2aLHPeICmxc+UsHZtjda2pKF7wR SZ2Khe+99UNoA3PgTIfgyPoE1j5h7vr4d/dMrg+UNdqsaz8prkkPTZbqRQKlXG3GC4oZ GX76Y56lxPDjxmi8TkeunHiZCcNjGvMv4wHB8ke0XGpRkuHpvuRFBbNaUT2WrzLY35z4 ZStsifClKU4PIhzbpsMGjnG/IRWuoeYYkXqy9rnaseHv6EInNYt8uPCsISmqngmt2sCU CxkQ== X-Gm-Message-State: APjAAAXMtly5tPmDxbF5xZv01BvhZ+jxafg1hUc3fe/YU3DGlMkArA+E 3PEEom5ctgxJmUpmfj6SNnc= X-Google-Smtp-Source: APXvYqw7+50H8r5YAiRCAAYjrc9tiVlTaS4wA2XI43DQf6QFqgX3O5KS3CwYd20nbcaN2AL68CrMBw== X-Received: by 2002:adf:df08:: with SMTP id y8mr7845005wrl.91.1554462023445; Fri, 05 Apr 2019 04:00:23 -0700 (PDT) Received: from [192.168.8.147] (69.248.23.93.rev.sfr.net. [93.23.248.69]) by smtp.gmail.com with ESMTPSA id t24sm2216554wmi.10.2019.04.05.04.00.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 04:00:22 -0700 (PDT) Subject: Re: NAT performance regression caused by vlan GRO support To: Florian Westphal , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vu?= =?UTF-8?Q?sen?= Cc: Toshiaki Makita , Felix Fietkau , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Toshiaki Makita , netdev@vger.kernel.org, "David S. Miller" , Stefano Brivio , Sabrina Dubroca , David Ahern , Jo-Philipp Wich , Koen Vandeputte References: <73223229-6bc0-2647-6952-975961811866@gmail.com> <75961408-fd62-0f12-bd4b-79008b27576c@gmail.com> <53588a9f-8cc8-0ee5-0947-8ab2b2e56f15@gmail.com> <45b6fe37-ba1a-91c2-1d4a-2d045793babd@nbd.name> <67d634cd-cf16-df21-7b8a-5d865d95e4e6@lab.ntt.co.jp> <87mul421sg.fsf@toke.dk> <20190405105151.7csiro6ib5zpaqsd@breakpoint.cc> From: Eric Dumazet Message-ID: Date: Fri, 5 Apr 2019 04:00:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190405105151.7csiro6ib5zpaqsd@breakpoint.cc> Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/05/2019 03:51 AM, Florian Westphal wrote: > Toke Høiland-Jørgensen wrote: >> As a first approximation, maybe just: >> >> if (!has_hardware_cksum_offload(netdev) && link_rate(netdev) <= 1Gbps) >> disable_gro(); > > I don't think its a good idea. For local delivery case, there is no > way to avoid the checksum cost, so might as well have GRO enabled. > We might add a sysctl or a way to tell GRO layer : Do not attempt checksumming if forwarding is enabled on the host. Basically GRO if NIC has provided checksum offload.