From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH 1/1] tap: comment fix Date: Fri, 17 Aug 2018 12:28:50 +0800 Message-ID: References: <20180816.123002.844201503080913720.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: girish.moodalbail@oracle.com, mst@redhat.com, willemb@google.com, viro@zeniv.linux.org.uk, wexu@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: David Miller , jianjian.wang1@gmail.com Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34056 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725789AbeHQHav (ORCPT ); Fri, 17 Aug 2018 03:30:51 -0400 In-Reply-To: <20180816.123002.844201503080913720.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018年08月17日 03:30, David Miller wrote: > From: Wang Jian > Date: Thu, 16 Aug 2018 21:01:27 +0800 > >> The tap_queue and the "tap_dev" are loosely coupled, not "macvlan_dev". >> >> And I also change one rcu_read_lock's place, seems can reduce rcu >> critical section a little. >> >> Signed-off-by: Wang Jian > This patch was corrupted by your email client, for example it turned > TAB characters into sequences of spaces. > > Please fix this, email a test patch to yourself, and do not resend the > patch to this mailing list until you can successfully extract and > cleanly apply the test patch you email to yourself. > > Thank you. Besides this, please split it into two patches. The RCU change does not belong to "comment fix" for sure. Thanks