From mboxrd@z Thu Jan 1 00:00:00 1970 From: Craig McGeachie Subject: Re: [RFC 0/1] Appletalk AARP probe broken by receipt of own broadcasts. Date: Sun, 19 Aug 2018 14:09:43 +1200 Message-ID: References: <20180819010739.26975-1-slapdau@gmail.com> <20180819013244.GA8950@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , netdev@vger.kernel.org, Craig McGeachie To: Andrew Lunn Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:39508 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725850AbeHSFVs (ORCPT ); Sun, 19 Aug 2018 01:21:48 -0400 Received: by mail-pf1-f195.google.com with SMTP id j8-v6so5124271pff.6 for ; Sat, 18 Aug 2018 19:12:01 -0700 (PDT) In-Reply-To: <20180819013244.GA8950@lunn.ch> Content-Language: en-NZ Sender: netdev-owner@vger.kernel.org List-ID: On 19/08/18 13:32, Andrew Lunn wrote: > On Sun, Aug 19, 2018 at 01:07:38PM +1200, Craig McGeachie wrote: >> I'm hoping I can find someone able and willing to test this patch. That >> requires someone still using netatalk 2.2.x with DDP, or some other DDP >> userspace application. This feels like a longshot. >> >> When netatalk 2.2.x starts up with DDP and sets the Appletalk node >> address, the kernel AARP code sends a probe packet for the address. It >> then receives its own probe packet and interprets that as some other >> node also trying to claim the address. It increments the address, tries >> again, and fails again ad nausium. Eventually the kernel module gives up >> and returns to netatalk which terminates with an error that it cannot >> get a node address. > > Hi Craig > > What Ethernet device are you seeing this problem with? > > I'm not sure an Ethernet device should receive its own broadcasts. > This might be a driver bug, not an AARP bug. > > Andrew > I run inside Virtualbox with the Realtek PCIe GBE Family Controller. Assuming I'm reading /sys/class/net/enp0s3/driver correctly, it's using the e1000 driver. However, it might not be the ethernet driver's fault. I've been a bit loose with terminology. Appletalk AARP probe packets aren't ethernet broadcasts as such; they're multicast packets, via the psnap driver, to hardware address 09:00:07:ff:ff:ff. Cheers, Craig.