From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BAE33B8BB2 for ; Fri, 6 Feb 2026 14:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386670; cv=none; b=Nzd0nzJfQH+yuDvjnyq0n2RqIAy/K+uxiCi4YPBbyRpiACS4/EoZueu1aNA1oBGaepTahJa6tXQbfmcfHbTCwxwJz7ltJSPX94TSFQ3rvjgy0QkLiwIYqrRc0pwAuy3nZYSfiMKhIYj6RwhDSRUoEK/vgl+Mlig38YhNJZR37r8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386670; c=relaxed/simple; bh=z4GNuMRZct0KcMBQZOFElH6rK3k1LgWIOdpyLUXQ8Zw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=APu+3u4fgGSbMWs4gGGgyCvpnI+7g624qcUzDvBFJJTqRmUxADshy/mBaKz52u9tkMUjLW8Mz6qnq/30RzNNs85D7DLjrcCCqyqNd9FXdrE/9TXETjkdEhW6SVTywHvvF/ijNkklVh3vHnHi62Rq+KgmyzlldBVGdO0htB9/dSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fWPksgV5; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fWPksgV5" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770386668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TR+sNHwRto6X97gwyNZ0eglR840iij69ujYUHSFBO8s=; b=fWPksgV5qmy0XKWUaSpnfstNbJxpx4If3eBbfXsWnD2dzDwIehAVQtOz4BSiGSAx6ZCyrr jSPxq7GfX/w6Iwq1f4Ozq2Tc4bH4DIadz3vKSQA74+cQtc9yCuIGtPT6ayVZwN4h8r2ZCd LXqXhU5HbWWJYnwsUYqsQE9kjR8cmPg= Date: Fri, 6 Feb 2026 14:04:24 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] dpll: zl3073x: Fix output pin phase adjustment sign To: Ivan Vecera , netdev@vger.kernel.org Cc: Prathosh Satish , Arkadiusz Kubalewski , Jiri Pirko , linux-kernel@vger.kernel.org References: <20260205181055.129768-1-ivecera@redhat.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20260205181055.129768-1-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 05/02/2026 18:10, Ivan Vecera wrote: > The output pin phase adjustment functions incorrectly negate the phase > compensation value. > > Per the ZL3073x datasheet, the output phase compensation register is > simply a signed two's complement integer where: > - Positive values move the phase later in time > - Negative values move the phase earlier in time > > No negation is required. The erroneous negation caused phase adjustments > to be applied in the wrong direction. > > Note that input pin phase adjustment correctly uses negation because the > hardware has an inverted convention for input references (positive moves > phase earlier, negative moves phase later). Is it common for DPLLs to act this way? > > Fixes: 6287262f761e ("dpll: zl3073x: Add support to adjust phase") > Signed-off-by: Ivan Vecera Anyways, with datasheet info being correctly read, the change LGTM Reviewed-by: Vadim Fedorenko