From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [iproute2-next v3 1/1] tipc: fixed node and name table listings Date: Fri, 18 May 2018 10:13:33 -0600 Message-ID: References: <1526565762-3681-1-git-send-email-jon.maloy@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: mohan.krishna.ghanta.krishnamurthy@ericsson.com, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net To: Jon Maloy , stephen@networkplumber.org, netdev@vger.kernel.org Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:45031 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbeERQNg (ORCPT ); Fri, 18 May 2018 12:13:36 -0400 Received: by mail-pl0-f68.google.com with SMTP id e6-v6so4841272plt.11 for ; Fri, 18 May 2018 09:13:36 -0700 (PDT) In-Reply-To: <1526565762-3681-1-git-send-email-jon.maloy@ericsson.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/17/18 8:02 AM, Jon Maloy wrote: > We make it easier for users to correlate between 128-bit node > identities and 32-bit node hash number by extending the 'node list' > command to also show the hash number. > > We also improve the 'nametable show' command to show the node identity > instead of the node hash number. Since the former potentially is much > longer than the latter, we make room for it by eliminating the (to the > user) irrelevant publication key. We also reorder some of the columns so > that the node id comes last, since this looks nicer and is more logical. > > --- > v2: Fixed compiler warning as per comment from David Ahern > v3: Fixed leaking socket as per comment from David Ahern > > Signed-off-by: Jon Maloy applied to iproute2-next. Thanks