From: Pkshih <pkshih@realtek.com>
To: Pkshih <pkshih@realtek.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Bernie Huang <phhuang@realtek.com>,
"open list:REALTEK WIRELESS DRIVER (rtw88)"
<linux-wireless@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: "kernel@collabora.com" <kernel@collabora.com>
Subject: RE: [PATCH v3] rtw88: check for validity before using a pointer
Date: Fri, 21 Jan 2022 07:14:30 +0000 [thread overview]
Message-ID: <d41cad1d43074b858209f3d7227c4e14@realtek.com> (raw)
In-Reply-To: <505cb763449e4b4ab493857e014e31a1@realtek.com>
> -----Original Message-----
> From: Pkshih <pkshih@realtek.com>
> Sent: Friday, December 24, 2021 5:01 PM
> To: Muhammad Usama Anjum <usama.anjum@collabora.com>; Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle
> Valo <kvalo@kernel.org>; David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Bernie
> Huang <phhuang@realtek.com>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@vger.kernel.org>;
> open list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> Cc: kernel@collabora.com
> Subject: RE: [PATCH v3] rtw88: check for validity before using a pointer
>
> > -----Original Message-----
> > From: Muhammad Usama Anjum <usama.anjum@collabora.com>
> > Sent: Friday, December 24, 2021 4:55 PM
> > To: Yan-Hsuan Chuang <tony0620emma@gmail.com>; Kalle Valo <kvalo@kernel.org>; David S. Miller
> > <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Pkshih <pkshih@realtek.com>; Bernie Huang
> > <phhuang@realtek.com>; open list:REALTEK WIRELESS DRIVER (rtw88) <linux-wireless@vger.kernel.org>; open
> > list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> > Cc: usama.anjum@collabora.com; kernel@collabora.com
> > Subject: [PATCH v3] rtw88: check for validity before using a pointer
> >
> > ieee80211_probereq_get() can return NULL. Pointer skb should be checked
> > for validty before use. If it is not valid, list of skbs needs to be
> > freed.
> >
> > Fixes: 10d162b2ed39 ("rtw88: 8822c: add ieee80211_ops::hw_scan")
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> [...]
>
I take this patch into my patchset [1], because my new patches are based this patch
related to fixes of hw_scan.
[1] https://lore.kernel.org/linux-wireless/20220121070813.9656-2-pkshih@realtek.com/T/#u
--
Ping-Ke
prev parent reply other threads:[~2022-01-21 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 8:54 [PATCH v3] rtw88: check for validity before using a pointer Muhammad Usama Anjum
2021-12-24 9:00 ` Pkshih
2022-01-21 7:14 ` Pkshih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d41cad1d43074b858209f3d7227c4e14@realtek.com \
--to=pkshih@realtek.com \
--cc=davem@davemloft.net \
--cc=kernel@collabora.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=tony0620emma@gmail.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).