From: Nicolai Buchwitz <nb@tipi-net.de>
To: Artemii Mashanov <ralerrdirsardx@gmail.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: bcmgenet: reject undersized RX classification rule buffers
Date: Sat, 21 Nov 2026 21:48:25 +0100 [thread overview]
Message-ID: <d4450968850aec1ae27961fd02db2ebb@tipi-net.de> (raw)
In-Reply-To: <20261121001550.732679-1-ralerrdirsardx@gmail.com>
Hi Artemii
Thanks for your patch.
On 21.11.2026 01:15, Artemii Mashanov wrote:
> bcmgenet_get_rxnfc() returns success with an incomplete list of RX
> classification rules when ETHTOOL_GRXCLSRLALL receives fewer slots
> than the number of installed rules.
>
> Return -EMSGSIZE when the next rule cannot fit in the caller's
> buffer. On success, report the actual number of copied rules.
The loop already stops at rule_cnt, so nothing overflows. The short
list only can happen if a rule is added between the count and dump
ioctls - and then ethtool -n just shows one rule fewer.
Fine as a cleanup, but please resend for net-next without the Fixes tag.
> The source-extracted ASan/UBSan regression tests passed.
Please drop this line, it doesn't apply to the kernel change.
> [...]
Thanks,
Nicolai
prev parent reply other threads:[~2026-11-21 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 0:15 [PATCH net] net: bcmgenet: reject undersized RX classification rule buffers Artemii Mashanov
2026-11-21 0:17 ` netdev-bot+sinfo
2026-11-21 18:58 ` Artemii Mashanov
2026-11-21 20:48 ` Nicolai Buchwitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4450968850aec1ae27961fd02db2ebb@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=ralerrdirsardx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).