From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE61C433ED for ; Tue, 13 Apr 2021 15:14:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43A67613B6 for ; Tue, 13 Apr 2021 15:14:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344603AbhDMPPQ (ORCPT ); Tue, 13 Apr 2021 11:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242392AbhDMPPO (ORCPT ); Tue, 13 Apr 2021 11:15:14 -0400 Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [IPv6:2a05:d018:a4d:6403:2dda:8093:274f:d185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FE2EC061756 for ; Tue, 13 Apr 2021 08:14:53 -0700 (PDT) Received: from dolphin.home (unknown [IPv6:2a00:23c6:5495:5e00:72b3:d5ff:feb1:e101]) by blyat.fensystems.co.uk (Postfix) with ESMTPSA id DEBBC4427E; Tue, 13 Apr 2021 15:14:46 +0000 (UTC) Subject: Re: xen-netback hotplug-status regression bug To: paul@xen.org, Wei Liu , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, Paul Durrant References: <58ccc3b7-9ccb-b9bf-84e7-4a023ccb5c56@ipxe.org> <54659eec-e315-5dc5-1578-d91633a80077@xen.org> From: Michael Brown Message-ID: Date: Tue, 13 Apr 2021 16:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <54659eec-e315-5dc5-1578-d91633a80077@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13/04/2021 11:55, Paul Durrant wrote: > Ok, so it sound like this was probably my misunderstanding of xenstore > semantics in the first place (although I'm sure I remember watch > registration failing for non-existent nodes at some point in the past... > that may have been with a non-upstream version of oxenstored though). > > Anyway... a reasonable fix would therefore be to read the node first and > only register the watch if it does exist. Thanks. Patch coming up shortly! Michael