netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alice Mikityanska" <alice.kernel@fastmail.im>
To: "Matthieu Baerts" <matttbe@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>
Cc: "Eric Dumazet" <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Alice Mikityanska" <alice@isovalent.com>
Subject: Re: [PATCH net-next 2/4] selftests: net: Lower threshold on debug kernels for big_tcp_tunnels.sh
Date: Wed, 19 Aug 2026 20:20:53 +0300	[thread overview]
Message-ID: <d4634ee7-28b4-42cc-9a5e-3467b0b22397@app.fastmail.com> (raw)
In-Reply-To: <ea0ae140-86e9-4578-a24a-d50fc0b19c4a@kernel.org>

On Sat, Aug 15, 2026, at 02:07, Matthieu Baerts wrote:
> Hi Alice,
>
> On 14/08/2026 21:41, Alice Mikityanska wrote:
>> From: Alice Mikityanska <alice@isovalent.com>
>> 
>> CONFIG_DEBUG_NET kernels run slower and generate fewer BIG TCP packets,
>> making the test flaky on upstream CI runners. Lower the default
>> threshold for those kernels.
>
> Thank you for looking at that!
>
>> Signed-off-by: Alice Mikityanska <alice@isovalent.com>
>> ---
>>  tools/testing/selftests/net/big_tcp_tunnels.sh | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/net/big_tcp_tunnels.sh b/tools/testing/selftests/net/big_tcp_tunnels.sh
>> index 9b7d0456bcc1..e27774eae20e 100755
>> --- a/tools/testing/selftests/net/big_tcp_tunnels.sh
>> +++ b/tools/testing/selftests/net/big_tcp_tunnels.sh
>> @@ -17,11 +17,25 @@ CLIENT_IP6="2001:db8::1:2"
>>  CLIENT_IP4_TUN="192.168.2.2"
>>  CLIENT_IP6_TUN="2001:db8::2:2"
>>  
>> -: "${PACKETS_THRESHOLD:=1000}"
>> -
>>  # Kselftest framework requirement - SKIP code is 4.
>>  ksft_skip=4
>>  
>> +is_debug() {
>> +	local config="/proc/config.gz"
>> +	[ -f "$config" ] || config="/boot/config-$(uname -r)"
>> +	[ -f "$config" ] || return 1 # No config found; assume non-debug.
>> +	gzip -dcfq "$config" | grep -qx 'CONFIG_DEBUG_NET=y' || return 1
>
> Are you sure it is CONFIG_DEBUG_NET that causes that? It shouldn't be
> that heavy.
>
> Do you not want to change the thresholds only for the -dbg runners using
> kernel/configs/debug.config? If yes, you should check if
> KSFT_MACHINE_SLOW == yes:

Thanks for the suggestion! I'll switch to KSFT_MACHINE_SLOW.

> https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style#dealing-with-slow-runners-in-performancelatency-tests
>
> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.

  reply	other threads:[~2026-08-19 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 19:41 [PATCH net-next 0/4] Improve stability of big_tcp_tunnels.sh selftest Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 1/4] selftests: net: Wait for netserver to launch Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 2/4] selftests: net: Lower threshold on debug kernels for big_tcp_tunnels.sh Alice Mikityanska
2026-08-14 23:07   ` Matthieu Baerts
2026-08-19 17:20     ` Alice Mikityanska [this message]
2026-08-14 19:41 ` [PATCH net-next 3/4] selftests: net: Lower threshold with csum offload off in big_tcp_tunnels.sh Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 4/4] selftests: net: Fix slow configurations " Alice Mikityanska
2026-08-19  9:25   ` Matthieu Baerts
2026-08-19 17:21     ` Alice Mikityanska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4634ee7-28b4-42cc-9a5e-3467b0b22397@app.fastmail.com \
    --to=alice.kernel@fastmail.im \
    --cc=alice@isovalent.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).