From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Luke Howard <lukeh@padl.com>,
Richard Cochran <richardcochran@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Cedric Jehasse <cedric.jehasse@gmail.com>,
Kieran Tyrrell <kieran@sienda.com>,
Max Holtmann <mh@rme-audio.de>, Max Hunter <max@huntershome.org>,
Christoph Mellauner <christoph.mellauner@joyned.at>,
Simon Gapp <simon.gapp@gapp-audio.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/3] net: dsa: mv88e6xxx: various hwstamp fixes
Date: Sat, 25 Jul 2026 17:54:53 +0200 [thread overview]
Message-ID: <d46fcc62-b032-4bf4-9397-a11f1b523125@lunn.ch> (raw)
In-Reply-To: <20260724165207.6a03c9db@kernel.org>
On Fri, Jul 24, 2026 at 04:52:07PM -0700, Jakub Kicinski wrote:
> On Sun, 19 Jul 2026 15:30:52 +1000 Luke Howard wrote:
> > Three fixes for improving the reliably of hardware timestamp acquisition
> > on Marvell switches. In our tests this eliminated missed timestamps in
> > ptp4l, whilst also preserving PTP event and general message ordering on
> > switches that support embedded timestamps.
>
> Do you know if there's any precedent in the existing upstream drivers
> for overriding the reserved bytes? It's not normal for devices to modify
> the ingress frames. Perhaps there's some precedent, but if not I think
> we should gate this (eg with a devlink param?)
>
> Andrew, do you have any opinion? Or perhaps Richard?
I have a dim memory of PHYs who change the packet by adding time
stamps. There are definitely DSA switches which can put the stamps in
the DSA header/trailer.
Andrew
next prev parent reply other threads:[~2026-07-25 15:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 5:30 [PATCH net-next v3 0/3] net: dsa: mv88e6xxx: various hwstamp fixes Luke Howard
2026-07-19 5:30 ` [PATCH net-next v3 1/3] net: dsa: mv88e6xxx: use ARRIVAL1 counter for all peer delay messages Luke Howard
2026-07-19 5:30 ` [PATCH net-next v3 2/3] net: dsa: mv88e6xxx: embedded PTP timestamp support Luke Howard
2026-07-24 23:48 ` Jakub Kicinski
2026-07-19 5:30 ` [PATCH net-next v3 3/3] net: dsa: mv88e6xxx: apply embedded PTP arrival times inline Luke Howard
2026-07-24 23:52 ` [PATCH net-next v3 0/3] net: dsa: mv88e6xxx: various hwstamp fixes Jakub Kicinski
2026-07-25 5:27 ` Luke Howard
2026-07-25 15:54 ` Andrew Lunn [this message]
2026-07-27 20:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d46fcc62-b032-4bf4-9397-a11f1b523125@lunn.ch \
--to=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=christoph.mellauner@joyned.at \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kieran@sienda.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukeh@padl.com \
--cc=max@huntershome.org \
--cc=mh@rme-audio.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=simon.gapp@gapp-audio.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox