* [PATCH] net: qcom/emac: make function emac_isr static
@ 2017-10-05 9:10 Colin King
2017-10-05 19:31 ` Timur Tabi
2017-10-06 4:27 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-10-05 9:10 UTC (permalink / raw)
To: Timur Tabi, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function emac_isr is local to the source and does not need to
be in global scope, so make it static.
Cleans up sparse warnings:
symbol 'emac_isr' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/qualcomm/emac/emac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c
index 759543512117..f477ba29c569 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac.c
+++ b/drivers/net/ethernet/qualcomm/emac/emac.c
@@ -130,7 +130,7 @@ static int emac_start_xmit(struct sk_buff *skb, struct net_device *netdev)
return emac_mac_tx_buf_send(adpt, &adpt->tx_q, skb);
}
-irqreturn_t emac_isr(int _irq, void *data)
+static irqreturn_t emac_isr(int _irq, void *data)
{
struct emac_irq *irq = data;
struct emac_adapter *adpt =
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: qcom/emac: make function emac_isr static
2017-10-05 9:10 [PATCH] net: qcom/emac: make function emac_isr static Colin King
@ 2017-10-05 19:31 ` Timur Tabi
2017-10-06 4:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Timur Tabi @ 2017-10-05 19:31 UTC (permalink / raw)
To: Colin King, netdev; +Cc: kernel-janitors, linux-kernel
On 10/05/2017 04:10 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> The function emac_isr is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warnings:
> symbol 'emac_isr' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
ACK
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: qcom/emac: make function emac_isr static
2017-10-05 9:10 [PATCH] net: qcom/emac: make function emac_isr static Colin King
2017-10-05 19:31 ` Timur Tabi
@ 2017-10-06 4:27 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-10-06 4:27 UTC (permalink / raw)
To: colin.king; +Cc: timur, netdev, kernel-janitors, linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Thu, 5 Oct 2017 10:10:23 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> The function emac_isr is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warnings:
> symbol 'emac_isr' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-06 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-05 9:10 [PATCH] net: qcom/emac: make function emac_isr static Colin King
2017-10-05 19:31 ` Timur Tabi
2017-10-06 4:27 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).