From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers Date: Wed, 29 Aug 2018 12:44:31 +0300 Message-ID: References: <20180828210117.6437-1-ar@cs.msu.ru> <20180828210117.6437-3-ar@cs.msu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Doug Ledford , Jason Gunthorpe , netdev@vger.kernel.org To: Arseny Maslennikov , linux-rdma@vger.kernel.org Return-path: Received: from mail-lj1-f196.google.com ([209.85.208.196]:34808 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727406AbeH2Nki (ORCPT ); Wed, 29 Aug 2018 09:40:38 -0400 Received: by mail-lj1-f196.google.com with SMTP id f8-v6so3832027ljk.1 for ; Wed, 29 Aug 2018 02:44:33 -0700 (PDT) In-Reply-To: <20180828210117.6437-3-ar@cs.msu.ru> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello! On 8/29/2018 12:01 AM, Arseny Maslennikov wrote: > Some InfiniBand network devices have multiple ports on the same PCI > function. Prior to this the kernel erroneously used the `dev_id' sysfs > field of those network interfaces to convey the port number to userspace. > > `dev_id' is currently reserved for distinguishing stacked ifaces > (e.g: VLANs) with the same hardware address as their parent device. > > Similar fixes to net/mlx4_en and many other drivers, which started > exporting this information through `dev_id' before 3.15, were accepted > into the kernel 4 years ago. > See 76a066f2a2a0268b565459c417b59724b5a3197b, commit message: > `net/mlx4_en: Expose port number through sysfs'. See commit 76a066f2a2a0 ("net/mlx4_en: Expose port number through sysfs"). > This commit is separated from the previous one since we may wish to > preserve backwards compatibility with userspace being already dependent > on `dev_id' being different. > > Signed-off-by: Arseny Maslennikov [...] MBR, Sergei