From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EC4818629 for ; Thu, 2 Nov 2023 12:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="miheRlgn" Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF4D4128 for ; Thu, 2 Nov 2023 05:27:34 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9d2d8343dc4so136664066b.0 for ; Thu, 02 Nov 2023 05:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698928053; x=1699532853; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+IlzWzsPzAqK/9VX5A1Cz696kpR/WLJvKy9oVavGOwE=; b=miheRlgn2VI7Gw4+l7yGtlPSUcI7qunnd2NS3l8JRonwHJmAw1FVw/qk8HI0BoEv+U PKQ8Zgv0OsZSxXSubfIpdIsFPAdGSA/Kv4TE+M0ueUdQYd+16y21IdvO1xTt7+bXDlEh yr5gnoFiGYTro/C3Eja3jY21ppUPyJQ419/Onx3Y/APGzL8PxzchQQNgyJhXypgolIie N4yDDrVN7igLsLO3hXKq5VP3Q06lQ0aCZURpVrpIFzqUjRKDKQ/pPcX1pLYnt5awV6Aw d4cu2MyYbEkpTv10H5TKl1rXSZwf7Og36k+oJC8oGCu9KBnsHORpUMMlCzD4VyybTtQs 9XMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698928053; x=1699532853; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+IlzWzsPzAqK/9VX5A1Cz696kpR/WLJvKy9oVavGOwE=; b=BjT5sz1RxuwYRblID5KYKo/qmkX+ZRmGoHoc3JAs1bi7hWZBfMZXaFYWHQJFJ6AMzF J8olfYWucw+8MFWYKVVj0onBavn8S9q7mMXYSntSx5+54nfXHfpV3OyYaz3IxcuYi2K5 b3wUncJ1XiLnzOpv0GGCSIaaiedl4Ww1jsnQSCKBWEMXx9C5ovU/HYYiFh+8hiQUKnJI +2UGFyyQCJijBSKnE9jO8kQrvABuRQ/6UBbW9dGSssSyyfgEg0f/0HHIU5aJ/9NcSntO TkB1KgSsATL+7oVkxQ8D2CjYg37YJxWFicTeSAtBmyb/8XN8chqp+DjR2ElxXtakwIpS gGbA== X-Gm-Message-State: AOJu0YwGfF+eA+aCA9J+zY0DnVgwBe6QOeAxGarVH0JbcRH0HeaPqgkU Acf9YoPo7y48O+d6h71/ngdcpw== X-Google-Smtp-Source: AGHT+IGWszk6J5oumn/g+kI0XIK3jFZLR+YKmegTZFfG8Z5Pys1g97UFM5dl5Wk+Zo/hdL47i+Sp9w== X-Received: by 2002:a17:907:9496:b0:9c7:59d1:b2c4 with SMTP id dm22-20020a170907949600b009c759d1b2c4mr4030509ejc.64.1698928053238; Thu, 02 Nov 2023 05:27:33 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i9-20020a1709061cc900b009b2cc87b8c3sm1074554ejh.52.2023.11.02.05.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 05:27:32 -0700 (PDT) Date: Thu, 2 Nov 2023 15:27:29 +0300 From: Dan Carpenter To: Florian Westphal Cc: Thadeu Lima de Souza Cascardo , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Pablo Neira Ayuso , Harshit Mogalapalli Subject: Re: [PATCH v2] netfilter: nf_tables: prevent OOB access in nft_byteorder_eval Message-ID: References: <20230705201232.GG3751@breakpoint.cc> <20230705210535.943194-1-cascardo@canonical.com> <20231102102846.GE6174@breakpoint.cc> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231102102846.GE6174@breakpoint.cc> On Thu, Nov 02, 2023 at 11:28:46AM +0100, Florian Westphal wrote: > Dan Carpenter wrote: > > This patch is correct, but shouldn't we fix the code for 64 bit writes > > as well? > > Care to send a patch? > Sure. Will do. regads, dan carpenter