From: Daniel Borkmann <daniel@iogearbox.net>
To: Yonghong Song <yhs@fb.com>, ast@fb.com, netdev@vger.kernel.org
Cc: kernel-team@fb.com
Subject: Re: [PATCH net] bpf: change bpf_probe_write_user to bpf_trace_printk in test_verifier
Date: Tue, 21 Nov 2017 21:35:34 +0100 [thread overview]
Message-ID: <d4954ebc-983c-ba4f-12db-ecb6438a8644@iogearbox.net> (raw)
In-Reply-To: <20171121192340.2366601-1-yhs@fb.com>
On 11/21/2017 08:23 PM, Yonghong Song wrote:
> There are four tests in test_verifier using bpf_probe_write_user
> helper. These four tests will emit the following kernel messages
> [ 12.974753] test_verifier[220] is installing a program with bpf_probe_write_user
> helper that may corrupt user memory!
> [ 12.979285] test_verifier[220] is installing a program with bpf_probe_write_user
> helper that may corrupt user memory!
> ......
>
> This may confuse certain users. This patch replaces bpf_probe_write_user
> with bpf_trace_printk. The test_verifier already uses bpf_trace_printk
> earlier in the test and a trace_printk warning message has been printed.
> So this patch does not emit any more kernel messages.
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
Applied to bpf tree, thanks Yonghong!
prev parent reply other threads:[~2017-11-21 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 19:23 [PATCH net] bpf: change bpf_probe_write_user to bpf_trace_printk in test_verifier Yonghong Song
2017-11-21 20:35 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4954ebc-983c-ba4f-12db-ecb6438a8644@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).