From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net] bpf: change bpf_probe_write_user to bpf_trace_printk in test_verifier Date: Tue, 21 Nov 2017 21:35:34 +0100 Message-ID: References: <20171121192340.2366601-1-yhs@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kernel-team@fb.com To: Yonghong Song , ast@fb.com, netdev@vger.kernel.org Return-path: Received: from www62.your-server.de ([213.133.104.62]:53195 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184AbdKUUfm (ORCPT ); Tue, 21 Nov 2017 15:35:42 -0500 In-Reply-To: <20171121192340.2366601-1-yhs@fb.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/21/2017 08:23 PM, Yonghong Song wrote: > There are four tests in test_verifier using bpf_probe_write_user > helper. These four tests will emit the following kernel messages > [ 12.974753] test_verifier[220] is installing a program with bpf_probe_write_user > helper that may corrupt user memory! > [ 12.979285] test_verifier[220] is installing a program with bpf_probe_write_user > helper that may corrupt user memory! > ...... > > This may confuse certain users. This patch replaces bpf_probe_write_user > with bpf_trace_printk. The test_verifier already uses bpf_trace_printk > earlier in the test and a trace_printk warning message has been printed. > So this patch does not emit any more kernel messages. > > Signed-off-by: Yonghong Song Applied to bpf tree, thanks Yonghong!