From: Eric Dumazet <eric.dumazet@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Ahmed S. Darwish" <a.darwish@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Zheng Yongjun <zhengyongjun3@huawei.com>,
Eric Dumazet <edumazet@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] net: sched: gred: dynamically allocate tc_gred_qopt_offload
Date: Tue, 19 Oct 2021 15:26:47 -0700 [thread overview]
Message-ID: <d49b4b0f-d1d9-fb24-0ffb-660c666c8a28@gmail.com> (raw)
In-Reply-To: <20211019191544.3063872-1-arnd@kernel.org>
On 10/19/21 12:15 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
>
> @@ -754,6 +759,10 @@ static int gred_init(struct Qdisc *sch, struct nlattr *opt,
> sch->limit = qdisc_dev(sch)->tx_queue_len
> * psched_mtu(qdisc_dev(sch));
>
> + table->opt = kzalloc(sizeof(table->opt), GFP_KERNEL);
sizeof(*table->opt) ?
> + if (!table->opt)
> + return -ENOMEM;
> +
> return gred_change_table_def(sch, tb[TCA_GRED_DPS], extack);
> }
>
prev parent reply other threads:[~2021-10-19 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 19:15 [PATCH] [v2] net: sched: gred: dynamically allocate tc_gred_qopt_offload Arnd Bergmann
2021-10-19 22:08 ` Jakub Kicinski
2021-10-19 22:26 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d49b4b0f-d1d9-fb24-0ffb-660c666c8a28@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=a.darwish@linutronix.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=xiyou.wangcong@gmail.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).