From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible Date: Wed, 12 Sep 2018 01:17:19 +0200 Message-ID: References: <20180911221536.12993-1-marex@denx.de> <20180911231246.GB11474@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Andrew Lunn Return-path: Received: from mail-out.m-online.net ([212.18.0.9]:44537 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725738AbeILESy (ORCPT ); Wed, 12 Sep 2018 00:18:54 -0400 In-Reply-To: <20180911231246.GB11474@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 09/12/2018 01:12 AM, Andrew Lunn wrote: > On Wed, Sep 12, 2018 at 12:15:36AM +0200, Marek Vasut wrote: >> Add DT compatible string for MV88E6352 switch. >> >> Signed-off-by: Marek Vasut >> Cc: Andrew Lunn >> --- >> drivers/net/dsa/mv88e6xxx/chip.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c >> index e07838430d16..15427380e32e 100644 >> --- a/drivers/net/dsa/mv88e6xxx/chip.c >> +++ b/drivers/net/dsa/mv88e6xxx/chip.c >> @@ -4796,6 +4796,10 @@ static const struct of_device_id mv88e6xxx_of_match[] = { >> .compatible = "marvell,mv88e6190", >> .data = &mv88e6xxx_table[MV88E6190], >> }, >> + { >> + .compatible = "marvell,mv88e6352", >> + .data = &mv88e6xxx_table[MV88E6352], >> + }, > > NACK. > > Not needed. Lots of devices use the 6352. It is compatible to the > marvell,mv88e6085. So I should have both values in my DT, that is compatible = "marvell,mv88e6352", "marvell,mv88e6085"; ? That works for me ... -- Best regards, Marek Vasut