From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3ECC4708A for ; Sat, 26 Nov 2022 14:15:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbiKZOPf (ORCPT ); Sat, 26 Nov 2022 09:15:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiKZOPe (ORCPT ); Sat, 26 Nov 2022 09:15:34 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC9AF1D312 for ; Sat, 26 Nov 2022 06:15:33 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id r8so8130460ljn.8 for ; Sat, 26 Nov 2022 06:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c7lsnrFz2J4XCfERjKRpvtXDg4lRZmdlG/n7oHHCiX0=; b=uL6T+tjTFarMty+fOPuM9bBuM6CyZdwX1GD0aoo+VJMs0BKYtvvXXVag2uR/zCOA84 EBQ1xKdylwBPJxw+TG//u/mnfKBMaHT69pedL4/Pbav5Wro3iMc0LFNaznqaKJ7HEi7q GYnVzDlks7f/xpGh8k0RDjorw3XR9d7sJs1kducgSNDos0LRAah/+D9yOAX+dXLtvylm V/9VhLKefv1cbRT2IRWGiErIjijEPOUe7VPX7X4RR4cryLxlItC0erXt6t5OvrRk6MVD gWIQjfFXfs3HxTIFpCJsxuMNyTG4XiHfB9u5sAS45mUSUgYrtR0CkYar4GKrX2yvR/rz 4KZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c7lsnrFz2J4XCfERjKRpvtXDg4lRZmdlG/n7oHHCiX0=; b=dlKQ7wlordfWqk11q6XeU74eszhk2sSG7J6oHuMVtauwjg2qnuigzmmjxJCB1b8wXS omVbiZYZW4witQiCq75N7AuDietEOfNERKvfg/ADKh9b+TtUjT/XBvo7rk0T5YQPweCq 2dnP1wD1GpQwmqZx7sbvK+9ebGN1LYyuUya1jqSvEve4MOMeu8/cInzQ5DGP13NwT+gg iXL4tXrSwz+XZen/jP9efdUsH4ZCoAl/Na+0E7KP60/XKgE82Zfs1KxS6Yyx/giGcEEq gzax7+I6SoyNxfiPYLPizeuDvjtQsrmrf+MY78mLE0ys+IxSr2y3+6SPseBNnhBkhi4A ZeNg== X-Gm-Message-State: ANoB5plJGUx1ThJyGqxVMZE2G4WNO4rmErr9ZIo5O5Rbu+dbGH5A6Yux 43nUplTwx+PCDG/F75cr5L714Q== X-Google-Smtp-Source: AA0mqf5kbp78CpD4O/sFH3Y2H/x7l7cEvjdfpKdgvpKHpas8x9/CLSHdVCjquQ/ZPRvURYLneLCFAw== X-Received: by 2002:a2e:be8c:0:b0:26e:95bb:d7cc with SMTP id a12-20020a2ebe8c000000b0026e95bbd7ccmr11017551ljr.203.1669472130993; Sat, 26 Nov 2022 06:15:30 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id b4-20020a2eb904000000b0025e00e0116esm349417ljb.128.2022.11.26.06.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 06:15:30 -0800 (PST) Message-ID: Date: Sat, 26 Nov 2022 15:15:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/3] dt-bindings: net: sun8i-emac: Fix snps,dwmac.yaml inheritance Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: LABBE Corentin , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org References: <20221125202008.64595-1-samuel@sholland.org> <20221125202008.64595-3-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20221125202008.64595-3-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 25/11/2022 21:20, Samuel Holland wrote: > The sun8i-emac binding extends snps,dwmac.yaml, and should accept all > properties defined there, including "mdio", "resets", and "reset-names". > However, validation currently fails for these properties because the > local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml > is only included inside an allOf block. Fix this by referencing > snps,dwmac.yaml at the top level. > > Signed-off-by: Samuel Holland > --- > > .../devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > I must admit you're right that this hides the warning from dtbs_check, but not because something in allOf should not be included. The problem is how disabled nodes are being parsed here by referenced schema (snps,dwmac.yaml) and probably is a bug in dtschema package. Best regards, Krzysztof