* [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource()
@ 2021-06-07 13:38 Yang Yingliang
2021-06-07 17:47 ` Florian Fainelli
2021-06-07 21:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-06-07 13:38 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: opendmb, f.fainelli, davem, kuba
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 5335244e4577..89d16c587bb7 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -423,6 +423,10 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv)
int id, ret;
pres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!pres) {
+ dev_err(&pdev->dev, "Invalid resource\n");
+ return -EINVAL;
+ }
memset(&res, 0, sizeof(res));
memset(&ppd, 0, sizeof(ppd));
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource()
2021-06-07 13:38 [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource() Yang Yingliang
@ 2021-06-07 17:47 ` Florian Fainelli
2021-06-07 21:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-06-07 17:47 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, netdev; +Cc: opendmb, davem, kuba
On 6/7/2021 6:38 AM, Yang Yingliang wrote:
> It will cause null-ptr-deref if platform_get_resource() returns NULL,
> we need check the return value.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource()
2021-06-07 13:38 [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource() Yang Yingliang
2021-06-07 17:47 ` Florian Fainelli
@ 2021-06-07 21:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-07 21:10 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, netdev, opendmb, f.fainelli, davem, kuba
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 7 Jun 2021 21:38:37 +0800 you wrote:
> It will cause null-ptr-deref if platform_get_resource() returns NULL,
> we need check the return value.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmmii.c | 4 ++++
> 1 file changed, 4 insertions(+)
Here is the summary with links:
- [net-next] net: bcmgenet: check return value after calling platform_get_resource()
https://git.kernel.org/netdev/net-next/c/74325bf01045
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-07 21:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-07 13:38 [PATCH net-next] net: bcmgenet: check return value after calling platform_get_resource() Yang Yingliang
2021-06-07 17:47 ` Florian Fainelli
2021-06-07 21:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).