From: Doug Ledford <dledford@redhat.com>
To: David Ahern <dsahern@gmail.com>,
Steve Wise <swise@opengridcomputing.com>,
leon@kernel.org
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes
Date: Tue, 15 May 2018 16:00:29 -0400 [thread overview]
Message-ID: <d4a8a280c94dd8db969bc52abe057af1fde89a4b.camel@redhat.com> (raw)
In-Reply-To: <c9d9c8dd-682e-ab38-a3af-6159adbebba7@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
On Tue, 2018-05-15 at 13:53 -0600, David Ahern wrote:
> sure for the above, but not the ones below.
>
> Before this patch, this program:
> $ cat a.c
> #include <uapi/rdma/rdma_netlink.h>
> #include <stdio.h>
>
> int main(void)
> {
> printf("RDMA_NLDEV_ATTR_NDEV_INDEX = %d\n", RDMA_NLDEV_ATTR_NDEV_INDEX);
>
> return 0;
> }
>
> prints this:
> $ ./a.out
> RDMA_NLDEV_ATTR_NDEV_INDEX = 50
>
> After this patch,
> $ ./a.out
> RDMA_NLDEV_ATTR_NDEV_INDEX = 58
I just sent an incremental fix to the list under separate cover. You
can squash that fix into Steve's patch and it should resolve the issue.
Or Steve can respin the set. Either way.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-05-15 20:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 15:43 [PATCH v2 iproute2-next 0/3] RDMA tool driver-specific resource tracking Steve Wise
2018-05-14 15:42 ` [PATCH v2 iproute2-next 1/3] rdma: update rdma_netlink.h to get new driver attributes Steve Wise
2018-05-15 19:37 ` David Ahern
2018-05-15 19:47 ` Doug Ledford
2018-05-15 19:53 ` David Ahern
2018-05-15 20:00 ` Doug Ledford [this message]
2018-05-15 20:01 ` David Ahern
2018-05-15 20:05 ` Doug Ledford
2018-05-15 20:29 ` Steve Wise
2018-05-15 20:25 ` Steve Wise
2018-05-15 19:52 ` Doug Ledford
2018-05-15 20:28 ` Steve Wise
2018-05-15 20:39 ` Doug Ledford
2018-05-14 15:42 ` [PATCH v2 iproute2-next 2/3] rdma: print driver resource attributes Steve Wise
2018-05-14 15:42 ` [PATCH v2 iproute2-next 3/3] rdma: update man pages Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a8a280c94dd8db969bc52abe057af1fde89a4b.camel@redhat.com \
--to=dledford@redhat.com \
--cc=dsahern@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).