From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH net-next v1] xen-netback: make copy batch size configurable Date: Mon, 13 Nov 2017 10:33:38 +0000 Message-ID: References: <20171110193458.14204-1-joao.m.martins@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "xen-devel@lists.xenproject.org" , Wei Liu To: 'Joao Martins' , "netdev@vger.kernel.org" Return-path: In-Reply-To: <20171110193458.14204-1-joao.m.martins@oracle.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" List-Id: netdev.vger.kernel.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IEpvYW8gTWFydGlucyBbbWFpbHRv OmpvYW8ubS5tYXJ0aW5zQG9yYWNsZS5jb21dCj4gU2VudDogMTAgTm92ZW1iZXIgMjAxNyAxOToz NQo+IFRvOiBuZXRkZXZAdmdlci5rZXJuZWwub3JnCj4gQ2M6IEpvYW8gTWFydGlucyA8am9hby5t Lm1hcnRpbnNAb3JhY2xlLmNvbT47IFdlaSBMaXUKPiA8d2VpLmxpdTJAY2l0cml4LmNvbT47IFBh dWwgRHVycmFudCA8UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyB4ZW4tCj4gZGV2ZWxAbGlzdHMu eGVucHJvamVjdC5vcmcKPiBTdWJqZWN0OiBbUEFUQ0ggbmV0LW5leHQgdjFdIHhlbi1uZXRiYWNr OiBtYWtlIGNvcHkgYmF0Y2ggc2l6ZQo+IGNvbmZpZ3VyYWJsZQo+IAo+IENvbW1pdCBlYjE3MjNh MjliOWEgKCJ4ZW4tbmV0YmFjazogcmVmYWN0b3IgZ3Vlc3QgcngiKSByZWZhY3RvcmVkIFJ4Cj4g aGFuZGxpbmcgYW5kIGFzIGEgcmVzdWx0IGRlY3JlYXNlZCBtYXggZ3JhbnQgY29weSBvcHMgZnJv bSA0MzUyIHRvIDY0Lgo+IEJlZm9yZSB0aGlzIGNvbW1pdCBpdCB3b3VsZCBkcmFpbiB0aGUgcnhf cXVldWUgKHdoaWxlIHRoZXJlIGFyZQo+IGVub3VnaCBzbG90cyBpbiB0aGUgcmluZyB0byBwdXQg cGFja2V0cykgdGhlbiBjb3B5IHRvIGFsbCBwYWdlcyBhbmQgd3JpdGUKPiByZXNwb25zZXMgb24g dGhlIHJpbmcuIFdpdGggdGhlIHJlZmFjdG9yIHdlIGRvIGFsbW9zdCB0aGUgc2FtZSBhbGJlaXQK PiB0aGUgbGFzdCB0d28gc3RlcHMgYXJlIGRvbmUgZXZlcnkgQ09QWV9CQVRDSF9TSVpFICg2NCkg Y29waWVzLgo+IAo+IEZvciBiaWcgcGFja2V0cywgdGhlIHZhbHVlIG9mIDY0IG1lYW5zIGNvcHlp bmcgMyBwYWNrZXRzIGJlc3QgY2FzZSBzY2VuYXJpbwo+ICgxNyBjb3BpZXMpIGFuZCB3b3JzdC1j YXNlIG9ubHkgMSBwYWNrZXQgKDM0IGNvcGllcywgaS5lLiBpZiBhbGwgZnJhZ3MKPiBwbHVzIGhl YWQgY3Jvc3MgdGhlIDRrIGdyYW50IGJvdW5kYXJ5KSB3aGljaCBjb3VsZCBiZSB0aGUgY2FzZSB3 aGVuCj4gcGFja2V0cyBnbyBmcm9tIGxvY2FsIGJhY2tlbmQgcHJvY2Vzcy4KPiAKPiBJbnN0ZWFk IG9mIG1ha2luZyBpdCBzdGF0aWMgdG8gNjQgZ3JhbnQgY29waWVzLCBsZXRzIGFsbG93IHRoZSB1 c2VyIHRvCj4gc2VsZWN0IGl0cyB2YWx1ZSAod2hpbGUga2VlcGluZyB0aGUgY3VycmVudCBhcyBk ZWZhdWx0KSBieSBpbnRyb2R1Y2luZwo+IHRoZSBgY29weV9iYXRjaF9zaXplYCBtb2R1bGUgcGFy YW1ldGVyLiBUaGlzIGFsbG93cyB1c2VycyB0byBzZWxlY3QKPiB0aGUgaGlnaGVyIGJhdGNoZXMg KGkuZS4gZm9yIGJldHRlciB0aHJvdWdocHV0IHdpdGggYmlnIHBhY2tldHMpIGFzIGl0Cj4gd2Fz IHByaW9yIHRvIHRoZSBhYm92ZSBtZW50aW9uZWQgY29tbWl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6 IEpvYW8gTWFydGlucyA8am9hby5tLm1hcnRpbnNAb3JhY2xlLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9uZXQveGVuLW5ldGJhY2svY29tbW9uLmggICAgfCAgNiArKysrLS0KPiAgZHJpdmVycy9uZXQv eGVuLW5ldGJhY2svaW50ZXJmYWNlLmMgfCAyNSArKysrKysrKysrKysrKysrKysrKysrKystCj4g IGRyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL25ldGJhY2suYyAgIHwgIDUgKysrKysKPiAgZHJpdmVy cy9uZXQveGVuLW5ldGJhY2svcnguYyAgICAgICAgfCAgNSArKysrLQo+ICA0IGZpbGVzIGNoYW5n ZWQsIDM3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbmV0L3hlbi1uZXRiYWNrL2NvbW1vbi5oIGIvZHJpdmVycy9uZXQveGVuLQo+IG5ldGJh Y2svY29tbW9uLmgKPiBpbmRleCBhNDZhMWU5NDUwNWQuLmE1ZmUzNmUwOThhNyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9jb21tb24uaAo+ICsrKyBiL2RyaXZlcnMvbmV0 L3hlbi1uZXRiYWNrL2NvbW1vbi5oCj4gQEAgLTEyOSw4ICsxMjksOSBAQCBzdHJ1Y3QgeGVudmlm X3N0YXRzIHsKPiAgI2RlZmluZSBDT1BZX0JBVENIX1NJWkUgNjQKPiAKPiAgc3RydWN0IHhlbnZp Zl9jb3B5X3N0YXRlIHsKPiAtCXN0cnVjdCBnbnR0YWJfY29weSBvcFtDT1BZX0JBVENIX1NJWkVd Owo+IC0JUklOR19JRFggaWR4W0NPUFlfQkFUQ0hfU0laRV07Cj4gKwlzdHJ1Y3QgZ250dGFiX2Nv cHkgKm9wOwo+ICsJUklOR19JRFggKmlkeDsKPiArCXVuc2lnbmVkIGludCBzaXplOwoKQ291bGQg eW91IG5hbWUgdGhpcyBiYXRjaF9zaXplLCBvciBzb21ldGhpbmcgbGlrZSB0aGF0IHRvIG1ha2Ug aXQgY2xlYXIgd2hhdCBpdCBtZWFucz8KCj4gIAl1bnNpZ25lZCBpbnQgbnVtOwo+ICAJc3RydWN0 IHNrX2J1ZmZfaGVhZCAqY29tcGxldGVkOwo+ICB9Owo+IEBAIC0zODEsNiArMzgyLDcgQEAgZXh0 ZXJuIHVuc2lnbmVkIGludCByeF9kcmFpbl90aW1lb3V0X21zZWNzOwo+ICBleHRlcm4gdW5zaWdu ZWQgaW50IHJ4X3N0YWxsX3RpbWVvdXRfbXNlY3M7Cj4gIGV4dGVybiB1bnNpZ25lZCBpbnQgeGVu dmlmX21heF9xdWV1ZXM7Cj4gIGV4dGVybiB1bnNpZ25lZCBpbnQgeGVudmlmX2hhc2hfY2FjaGVf c2l6ZTsKPiArZXh0ZXJuIHVuc2lnbmVkIGludCB4ZW52aWZfY29weV9iYXRjaF9zaXplOwo+IAo+ ICAjaWZkZWYgQ09ORklHX0RFQlVHX0ZTCj4gIGV4dGVybiBzdHJ1Y3QgZGVudHJ5ICp4ZW5fbmV0 YmFja19kYmdfcm9vdDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50 ZXJmYWNlLmMgYi9kcml2ZXJzL25ldC94ZW4tCj4gbmV0YmFjay9pbnRlcmZhY2UuYwo+IGluZGV4 IGQ2ZGZmMzQ3Zjg5Ni4uYTU1ODg2OGE4ODNmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbmV0L3hl bi1uZXRiYWNrL2ludGVyZmFjZS5jCj4gKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svaW50 ZXJmYWNlLmMKPiBAQCAtNTE2LDcgKzUxNiwyMCBAQCBzdHJ1Y3QgeGVudmlmICp4ZW52aWZfYWxs b2Moc3RydWN0IGRldmljZSAqcGFyZW50LAo+IGRvbWlkX3QgZG9taWQsCj4gCj4gIGludCB4ZW52 aWZfaW5pdF9xdWV1ZShzdHJ1Y3QgeGVudmlmX3F1ZXVlICpxdWV1ZSkKPiAgewo+ICsJaW50IHNp emUgPSB4ZW52aWZfY29weV9iYXRjaF9zaXplOwoKdW5zaWduZWQgaW50Cgo+ICAJaW50IGVyciwg aTsKPiArCXZvaWQgKmFkZHI7Cj4gKwo+ICsJYWRkciA9IHZ6YWxsb2Moc2l6ZSAqIHNpemVvZihz dHJ1Y3QgZ250dGFiX2NvcHkpKTsKCkRvZXMgdGhlIG1lbW9yeSBuZWVkIHRvIGJlIHplcm9lZD8K Cj4gKwlpZiAoIWFkZHIpCj4gKwkJZ290byBlcnI7Cj4gKwlxdWV1ZS0+cnhfY29weS5vcCA9IGFk ZHI7Cj4gKwo+ICsJYWRkciA9IHZ6YWxsb2Moc2l6ZSAqIHNpemVvZihSSU5HX0lEWCkpOwoKTGlr ZXdpc2UuCgo+ICsJaWYgKCFhZGRyKQo+ICsJCWdvdG8gZXJyOwo+ICsJcXVldWUtPnJ4X2NvcHku aWR4ID0gYWRkcjsKPiArCXF1ZXVlLT5yeF9jb3B5LnNpemUgPSBzaXplOwo+IAo+ICAJcXVldWUt PmNyZWRpdF9ieXRlcyA9IHF1ZXVlLT5yZW1haW5pbmdfY3JlZGl0ID0gfjBVTDsKPiAgCXF1ZXVl LT5jcmVkaXRfdXNlYyAgPSAwVUw7Cj4gQEAgLTU0NCw3ICs1NTcsNyBAQCBpbnQgeGVudmlmX2lu aXRfcXVldWUoc3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpCj4gIAkJCQkgcXVldWUtPm1tYXBf cGFnZXMpOwo+ICAJaWYgKGVycikgewo+ICAJCW5ldGRldl9lcnIocXVldWUtPnZpZi0+ZGV2LCAi Q291bGQgbm90IHJlc2VydmUKPiBtbWFwX3BhZ2VzXG4iKTsKPiAtCQlyZXR1cm4gLUVOT01FTTsK PiArCQlnb3RvIGVycjsKPiAgCX0KPiAKPiAgCWZvciAoaSA9IDA7IGkgPCBNQVhfUEVORElOR19S RVFTOyBpKyspIHsKPiBAQCAtNTU2LDYgKzU2OSwxMyBAQCBpbnQgeGVudmlmX2luaXRfcXVldWUo c3RydWN0IHhlbnZpZl9xdWV1ZSAqcXVldWUpCj4gIAl9Cj4gCj4gIAlyZXR1cm4gMDsKPiArCj4g K2VycjoKPiArCWlmIChxdWV1ZS0+cnhfY29weS5vcCkKPiArCQl2ZnJlZShxdWV1ZS0+cnhfY29w eS5vcCk7Cgp2ZnJlZSBpcyBzYWZlIHRvIGJlIGNhbGxlZCB3aXRoIE5VTEwuCgo+ICsJaWYgKHF1 ZXVlLT5yeF9jb3B5LmlkeCkKPiArCQl2ZnJlZShxdWV1ZS0+cnhfY29weS5pZHgpOwo+ICsJcmV0 dXJuIC1FTk9NRU07Cj4gIH0KPiAKPiAgdm9pZCB4ZW52aWZfY2Fycmllcl9vbihzdHJ1Y3QgeGVu dmlmICp2aWYpCj4gQEAgLTc4OCw2ICs4MDgsOSBAQCB2b2lkIHhlbnZpZl9kaXNjb25uZWN0X2N0 cmwoc3RydWN0IHhlbnZpZiAqdmlmKQo+ICAgKi8KPiAgdm9pZCB4ZW52aWZfZGVpbml0X3F1ZXVl KHN0cnVjdCB4ZW52aWZfcXVldWUgKnF1ZXVlKQo+ICB7Cj4gKwl2ZnJlZShxdWV1ZS0+cnhfY29w eS5vcCk7Cj4gKwl2ZnJlZShxdWV1ZS0+cnhfY29weS5pZHgpOwo+ICsJcXVldWUtPnJ4X2NvcHku c2l6ZSA9IDA7Cj4gIAlnbnR0YWJfZnJlZV9wYWdlcyhNQVhfUEVORElOR19SRVFTLCBxdWV1ZS0+ bW1hcF9wYWdlcyk7Cj4gIH0KPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQveGVuLW5ldGJh Y2svbmV0YmFjay5jIGIvZHJpdmVycy9uZXQveGVuLQo+IG5ldGJhY2svbmV0YmFjay5jCj4gaW5k ZXggYTI3ZGFhMjNjOWRjLi4zYTVlMWQ3YWMyZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQv eGVuLW5ldGJhY2svbmV0YmFjay5jCj4gKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svbmV0 YmFjay5jCj4gQEAgLTk2LDYgKzk2LDExIEBAIHVuc2lnbmVkIGludCB4ZW52aWZfaGFzaF9jYWNo ZV9zaXplID0KPiBYRU5WSUZfSEFTSF9DQUNIRV9TSVpFX0RFRkFVTFQ7Cj4gIG1vZHVsZV9wYXJh bV9uYW1lZChoYXNoX2NhY2hlX3NpemUsIHhlbnZpZl9oYXNoX2NhY2hlX3NpemUsIHVpbnQsCj4g MDY0NCk7Cj4gIE1PRFVMRV9QQVJNX0RFU0MoaGFzaF9jYWNoZV9zaXplLCAiTnVtYmVyIG9mIGZs b3dzIGluIHRoZSBoYXNoCj4gY2FjaGUiKTsKPiAKPiArLyogVGhpcyBpcyB0aGUgbWF4aW11bSBi YXRjaCBvZiBncmFudCBjb3BpZXMgb24gUnggKi8KPiArdW5zaWduZWQgaW50IHhlbnZpZl9jb3B5 X2JhdGNoX3NpemUgPSBDT1BZX0JBVENIX1NJWkU7Cj4gK21vZHVsZV9wYXJhbV9uYW1lZChjb3B5 X2JhdGNoX3NpemUsIHhlbnZpZl9jb3B5X2JhdGNoX3NpemUsIHVpbnQsCj4gMDY0NCk7Cj4gK01P RFVMRV9QQVJNX0RFU0MoY29weV9iYXRjaF9zaXplLCAiTWF4aW11bSBiYXRjaCBvZiBncmFudCBj b3BpZXMKPiBvbiBSeCIpOwo+ICsKPiAgc3RhdGljIHZvaWQgeGVudmlmX2lkeF9yZWxlYXNlKHN0 cnVjdCB4ZW52aWZfcXVldWUgKnF1ZXVlLCB1MTYKPiBwZW5kaW5nX2lkeCwKPiAgCQkJICAgICAg IHU4IHN0YXR1cyk7Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3J4 LmMgYi9kcml2ZXJzL25ldC94ZW4tbmV0YmFjay9yeC5jCj4gaW5kZXggYjFjZjdjNmY0MDdhLi43 OTNhODVmNjFmOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9uZXQveGVuLW5ldGJhY2svcnguYwo+ ICsrKyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRiYWNrL3J4LmMKPiBAQCAtMTY4LDExICsxNjgsMTQg QEAgc3RhdGljIHZvaWQgeGVudmlmX3J4X2NvcHlfYWRkKHN0cnVjdAo+IHhlbnZpZl9xdWV1ZSAq cXVldWUsCj4gIAkJCSAgICAgICBzdHJ1Y3QgeGVuX25ldGlmX3J4X3JlcXVlc3QgKnJlcSwKPiAg CQkJICAgICAgIHVuc2lnbmVkIGludCBvZmZzZXQsIHZvaWQgKmRhdGEsIHNpemVfdCBsZW4pCj4g IHsKPiArCXVuc2lnbmVkIGludCBiYXRjaF9zaXplOwo+ICAJc3RydWN0IGdudHRhYl9jb3B5ICpv cDsKPiAgCXN0cnVjdCBwYWdlICpwYWdlOwo+ICAJc3RydWN0IHhlbl9wYWdlX2ZvcmVpZ24gKmZv cmVpZ247Cj4gCj4gLQlpZiAocXVldWUtPnJ4X2NvcHkubnVtID09IENPUFlfQkFUQ0hfU0laRSkK PiArCWJhdGNoX3NpemUgPSBtaW4oeGVudmlmX2NvcHlfYmF0Y2hfc2l6ZSwgcXVldWUtPnJ4X2Nv cHkuc2l6ZSk7CgpTdXJlbHkgcXVldWUtPnJ4X2NvcHkuc2l6ZSBhbmQgeGVudmlmX2NvcHlfYmF0 Y2hfc2l6ZSBhcmUgYWx3YXlzIGlkZW50aWNhbD8gV2h5IGRvIHlvdSBuZWVkIHRoaXMgc3RhdGVt ZW50IChhbmQgaGVuY2Ugc3RhY2sgdmFyaWFibGUpPwoKICBQYXVsCgo+ICsKPiArCWlmIChxdWV1 ZS0+cnhfY29weS5udW0gPT0gYmF0Y2hfc2l6ZSkKPiAgCQl4ZW52aWZfcnhfY29weV9mbHVzaChx dWV1ZSk7Cj4gCj4gIAlvcCA9ICZxdWV1ZS0+cnhfY29weS5vcFtxdWV1ZS0+cnhfY29weS5udW1d Owo+IC0tCj4gMi4xMS4wCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpo dHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==