From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH 6/8] can: mcp251x: Don't use pdata->model for chip selection anymore Date: Mon, 18 Oct 2010 15:49:11 +0200 Message-ID: References: <1287408674-15412-1-git-send-email-mkl@pengutronix.de> <1287408674-15412-7-git-send-email-mkl@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: , , Christian Pellegrin To: Marc Kleine-Budde Return-path: Received: from inca-roads.misterjones.org ([213.251.177.50]:41110 "EHLO inca-roads.misterjones.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755982Ab0JROMF (ORCPT ); Mon, 18 Oct 2010 10:12:05 -0400 In-Reply-To: <1287408674-15412-7-git-send-email-mkl@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 18 Oct 2010 15:31:12 +0200, Marc Kleine-Budde wrote: > Since commit e446630c960946b5c1762e4eadb618becef599e7, i.e. v2.6.35-rc1, > the mcp251x chip model can be selected via the modalias member in the > struct spi_board_info. The driver stores the actual model in the > struct mcp251x_platform_data. > > From the driver point of view the platform_data should be read only. > Since all in-tree users of the mcp251x have already been converted to > the modalias method, this patch moves the "model" member from the > struct mcp251x_platform_data to the driver's private data structure. > > Signed-off-by: Marc Kleine-Budde > Cc: Christian Pellegrin > Cc: Marc Zyngier Acked-by: Marc Zyngier -- Who you jivin' with that Cosmik Debris?