From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support Date: Tue, 5 Jun 2018 12:27:40 -0700 Message-ID: References: <20180605045812.17977-1-kai.heng.feng@canonical.com> <9D9E2AF1-CD59-425B-85E9-DB89D620CA67@canonical.com> <20180605172805.GD30381@bhelgaas-glaptop.roam.corp.google.com> <20180605191142.GA214338@bhelgaas-glaptop.roam.corp.google.com> <6c6b579a-5be4-ccc0-f64c-9998e51145f5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Kai Heng Feng , "jrg.otte@gmail.com" , David Miller , Hayes Wang , "romieu@fr.zoreil.com" , Linux Netdev List , Linux Kernel Mailing List , Hau , linux-pci@vger.kernel.org To: Heiner Kallweit , Bjorn Helgaas , Ryankao Return-path: In-Reply-To: <6c6b579a-5be4-ccc0-f64c-9998e51145f5@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 06/05/2018 12:17 PM, Heiner Kallweit wrote: > On 05.06.2018 21:11, Bjorn Helgaas wrote: >> [+cc linux-pci] >> >> On Tue, Jun 05, 2018 at 12:28:05PM -0500, Bjorn Helgaas wrote: >>> On Tue, Jun 05, 2018 at 06:34:09AM +0000, Ryankao wrote: >>>> Add realtek folk Hau >>>> >>>> -----Original Message----- >>>> From: Kai Heng Feng [mailto:kai.heng.feng@canonical.com] >>>> Sent: Tuesday, June 05, 2018 1:02 PM >>>> To: jrg.otte@gmail.com >>>> Cc: David Miller ; Hayes Wang ; hkallweit1@gmail.com; romieu@fr.zoreil.com; Linux Netdev List ; Linux Kernel Mailing List ; Ryankao >>>> Subject: Re: [PATCH] r8169: Reinstate ALDPS and ASPM support >>>> >>>> Hi Jörg Otte, >>>> >>>> Can you give this patch a try? >>>> >>>> Since you are the only one that reported ALDPS/ASPM regression, >>>> >>>> And I think this patch should solve the issue you had [1]. >>>> >>>> Hopefully we don't need to go down the rabbit hole of blacklist/whitelist... >>>> >>>> Kai-Heng >>>> >>>> [1] https://lkml.org/lkml/2013/1/5/36 >>> >>> I have no idea what ALDPS is. It's not mentioned in the PCIe spec, so >>> presumably it's some Realtek-specific thing. ASPM is a generic PCIe >>> thing. Changes to these two things should be in separate patches so >>> they don't get tangled up. >>> > ALDPS = Advanced Link Down Power Saving > And yes, it's a Realtek feature. Link as in Ethernet link or PCI(e) link? Sorry too lazy to let me google that for myself :) -- Florian