From: Matthieu Baerts <matttbe@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: "Donald Hunter" <donald.hunter@gmail.com>,
netdev@vger.kernel.org, "Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Jan Stancek" <jstancek@redhat.com>,
"Asbjørn Sloth Tønnesen" <ast@fiberby.net>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Ido Schimmel" <idosch@nvidia.com>,
"Guillaume Nault" <gnault@redhat.com>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Petr Machata" <petrm@nvidia.com>
Subject: Re: [PATCHv3 net-next 3/3] tools: ynl: add YNL test framework
Date: Thu, 13 Nov 2025 15:26:52 +0100 [thread overview]
Message-ID: <d59be940-69ec-414d-be93-68da5042ab0f@kernel.org> (raw)
In-Reply-To: <aRXQIJMCLTaqIZLu@fedora>
On 13/11/2025 13:33, Hangbin Liu wrote:
> On Thu, Nov 13, 2025 at 10:59:49AM +0100, Matthieu Baerts wrote:
(...)
>>>> If there is a need to know which tests have failed, why not using (K)TAP
>>>> format for the output?
>>>
>>> I feel it's too heavy to copy the (K)TAP format here. I would just using the
>>> exit code unless Jakub ask to using the specific output format
>>
>> OK, I thought it was just a question of changing your 'echo' from "PASS"
>> and "FAIL" to "(not )ok ${COUNTER} (...)" + print the header and the
>> number of tests. But sure, if this format is not needed, no need to bother.
>
> Oh, this looks reasonable. I will try add a helper for the output.
I don't know if it is a good idea for these tests, but maybe you can use
existing ones from tools/testing/selftests/kselftest/ktap_helpers.sh?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-11-13 14:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 9:59 [PATCHv3 net-next 0/3] Add YNL test framework and library improvements Hangbin Liu
2025-11-10 9:59 ` [PATCHv3 net-next 1/3] tools: ynl: Add MAC address parsing support Hangbin Liu
2025-11-11 10:07 ` Donald Hunter
2025-11-10 9:59 ` [PATCHv3 net-next 2/3] netlink: specs: support ipv4-or-v6 for dual-stack fields Hangbin Liu
2025-11-10 16:38 ` Asbjørn Sloth Tønnesen
2025-11-11 10:38 ` Donald Hunter
2025-11-10 10:00 ` [PATCHv3 net-next 3/3] tools: ynl: add YNL test framework Hangbin Liu
2025-11-11 11:51 ` Donald Hunter
2025-11-13 3:57 ` Hangbin Liu
2025-11-13 6:06 ` Hangbin Liu
2025-11-13 9:21 ` Matthieu Baerts
2025-11-13 9:51 ` Hangbin Liu
2025-11-13 9:59 ` Matthieu Baerts
2025-11-13 12:33 ` Hangbin Liu
2025-11-13 14:26 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d59be940-69ec-414d-be93-68da5042ab0f@kernel.org \
--to=matttbe@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jstancek@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=sd@queasysnail.net \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).