From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE84314D449 for ; Tue, 4 Jun 2024 23:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717545199; cv=none; b=XwgTykLd/BYz+dfkxrey/DlJLDli3YoGQgb7Aob/nkLPj5bvxG9u5gjTq2rFFM9mleZo3BcbrpeqOraohRGFry8/pzoaLXkh/bnqLgzQgGC07497reqmOyrpnjZUa5b0H1CQgKKYrIC3DqA49+v0gCH36KC/piUn9gYq/a9Zbjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717545199; c=relaxed/simple; bh=Zpoq44WjqJcKjXQIxwNH1FdsFxaKOKAngaXTWh/BTD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kKougnEd/Xh8WxIvdLsLndN9jxDaUo5xRXhZQzMmPf46sqleWAK0B0+6o2jSkUzOcXlF4PK5N5ITdZKAX6k3W+ItVAMXNfUH2nM69OF8mXuvbOaIjX/luScdf5VVmQAqWoqV3HNHqBN+bF2DGqq/iT29RpjyrOrO97o4rb1Kp4A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eXmgrUVk; arc=none smtp.client-ip=91.218.175.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eXmgrUVk" X-Envelope-To: gregkh@linuxfoundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717545195; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nsvW5WrtUFha+bvJijPjsgy9DS6DwvlLBlXNWCE80vw=; b=eXmgrUVkEBUpU3p9t9WrhsjablrCRXDWmg2chcN6zkkIluwx/6ziwu64ZYgDmHzYgCTV0V L1eH4KkCnbdYWnF76QoBNIM5MTQUfcf/hl/5/HoVSvUx5sM0K8C8Tjwuel23THKE+LrgqI HMlXTMc5wOuw+d1bHCbrCp69H6bvTVk= X-Envelope-To: kuba@kernel.org X-Envelope-To: jirislaby@kernel.org X-Envelope-To: jonathan.lemon@gmail.com X-Envelope-To: linux-serial@vger.kernel.org X-Envelope-To: netdev@vger.kernel.org Message-ID: Date: Wed, 5 Jun 2024 00:53:13 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 net] ptp: ocp: adjust serial port symlink creation To: Greg Kroah-Hartman Cc: Jakub Kicinski , Jiri Slaby , Jonathan Lemon , linux-serial@vger.kernel.org, netdev@vger.kernel.org References: <20240510110405.15115-1-vadim.fedorenko@linux.dev> <2024051046-decimeter-devotee-076a@gregkh> <2024060428-childcare-clunky-067c@gregkh> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <2024060428-childcare-clunky-067c@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 04/06/2024 12:50, Greg Kroah-Hartman wrote: > On Wed, May 22, 2024 at 01:39:21PM +0100, Vadim Fedorenko wrote: >> On 10/05/2024 12:13, Greg Kroah-Hartman wrote: >>> On Fri, May 10, 2024 at 11:04:05AM +0000, Vadim Fedorenko wrote: >>>> The commit b286f4e87e32 ("serial: core: Move tty and serdev to be children >>>> of serial core port device") changed the hierarchy of serial port devices >>>> and device_find_child_by_name cannot find ttyS* devices because they are >>>> no longer directly attached. Add some logic to restore symlinks creation >>>> to the driver for OCP TimeCard. >>>> >>>> Fixes: b286f4e87e32 ("serial: core: Move tty and serdev to be children of serial core port device") >>>> Signed-off-by: Vadim Fedorenko >>>> --- >>>> v2: >>>> add serial/8250 maintainers >>>> --- >>>> drivers/ptp/ptp_ocp.c | 30 +++++++++++++++++++++--------- >>>> 1 file changed, 21 insertions(+), 9 deletions(-) >>> >>> Hi, >>> >>> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him >>> a patch that has triggered this response. He used to manually respond >>> to these common problems, but in order to save his sanity (he kept >>> writing the same thing over and over, yet to different people), I was >>> created. Hopefully you will not take offence and will fix the problem >>> in your patch and resubmit it so that it can be accepted into the Linux >>> kernel tree. >>> >>> You are receiving this message because of the following common error(s) >>> as indicated below: >>> >>> - You have marked a patch with a "Fixes:" tag for a commit that is in an >>> older released kernel, yet you do not have a cc: stable line in the >>> signed-off-by area at all, which means that the patch will not be >>> applied to any older kernel releases. To properly fix this, please >>> follow the documented rules in the >>> Documentation/process/stable-kernel-rules.rst file for how to resolve >>> this. >>> >>> If you wish to discuss this problem further, or you have questions about >>> how to resolve this issue, please feel free to respond to this email and >>> Greg will reply once he has dug out from the pending patches received >>> from other developers. >> >> Hi Greg! >> >> Just gentle ping, I'm still looking for better solution for serial >> device lookup in TimeCard driver. > > See my comment on the other patch in this thread. > > In short, you shouldn't need to do any of this. Got it, thanks. I'll try to find another way. > thanks, > > greg k-h