From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AA4C433E0 for ; Wed, 15 Jul 2020 08:43:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DF7A20657 for ; Wed, 15 Jul 2020 08:43:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BdCsp6n4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729485AbgGOInS (ORCPT ); Wed, 15 Jul 2020 04:43:18 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53158 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729503AbgGOInR (ORCPT ); Wed, 15 Jul 2020 04:43:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594802596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g3ATeHeFF1J37NbSRujlNcK6+iTDVTNL3b6nVYG9gNI=; b=BdCsp6n4x6lml+v1/P0NIfy4epVqOnRGmryBJDQYcrkTzngcy0PkdV/sP3ZFTgI26R2zV8 jfJOT09/hSkw9a6JaHQV0RqPTooqGlECq3YTRpZvxEXw4Lh7AqCejgu9E5uMV5SSYPqxRd ZRPSO5beS5puYTu/ihXOMitk4AS4yEc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-218-k8z0oujvNH-_u1V4kBvS-Q-1; Wed, 15 Jul 2020 04:43:14 -0400 X-MC-Unique: k8z0oujvNH-_u1V4kBvS-Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A5FC100CCC1; Wed, 15 Jul 2020 08:43:13 +0000 (UTC) Received: from [10.72.13.230] (ovpn-13-230.pek2.redhat.com [10.72.13.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F7D66FEF4; Wed, 15 Jul 2020 08:43:06 +0000 (UTC) Subject: Re: [PATCH 5/7] virtio_vdpa: init IRQ offloading function pointers to NULL. To: "Zhu, Lingshan" , mst@redhat.com, alex.williamson@redhat.com, pbonzini@redhat.com, sean.j.christopherson@intel.com, wanpengli@tencent.com Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com References: <1594565366-3195-1-git-send-email-lingshan.zhu@intel.com> <1594565366-3195-5-git-send-email-lingshan.zhu@intel.com> <276bf939-8e12-e28a-64f7-1767851e0db5@redhat.com> From: Jason Wang Message-ID: Date: Wed, 15 Jul 2020 16:43:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020/7/13 下午6:20, Zhu, Lingshan wrote: > > > On 7/13/2020 4:28 PM, Jason Wang wrote: >> >> On 2020/7/12 下午10:49, Zhu Lingshan wrote: >>> This commit initialize IRQ offloading function pointers in >>> virtio_vdpa_driver to NULL. Becasue irq offloading only focus >>> on VMs for vhost_vdpa. >>> >>> Signed-off-by: Zhu Lingshan >>> --- >>>   drivers/virtio/virtio_vdpa.c | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/virtio/virtio_vdpa.c >>> b/drivers/virtio/virtio_vdpa.c >>> index c30eb55..1e8acb9 100644 >>> --- a/drivers/virtio/virtio_vdpa.c >>> +++ b/drivers/virtio/virtio_vdpa.c >>> @@ -386,6 +386,8 @@ static void virtio_vdpa_remove(struct >>> vdpa_device *vdpa) >>>       }, >>>       .probe    = virtio_vdpa_probe, >>>       .remove = virtio_vdpa_remove, >>> +    .setup_vq_irq = NULL, >>> +    .unsetup_vq_irq = NULL, >>>   }; >> >> >> Is this really needed consider the it's static? >> >> Thanks > This is for readability, to show they are NULL, so virtio_vdpa would not go through irq forwarding / offloading. > > Does this make sense? Probably not, please refer what is done by other subsystems. Thanks > > Thanks, > BR > Zhu Lingshan >> >> >>> module_vdpa_driver(virtio_vdpa_driver); >>