From: David Ahern <dsahern@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next] tc/police: Allow 64 bit burst size
Date: Thu, 11 Sep 2025 14:50:53 -0600 [thread overview]
Message-ID: <d5b7afbf-318a-49c8-9e40-bcb4b452201b@gmail.com> (raw)
In-Reply-To: <CAM0EoMmJaC3OAncWnUOkz6mn7BVXudnG1YKUYZomUkbVu8Zb+g@mail.gmail.com>
On 9/9/25 9:32 PM, Jamal Hadi Salim wrote:
>
> Please run tdc tests. David/Stephen - can we please make this a
> requirement for iproute2 tc related changes?
I will try to remember to run tdc tests for tc patches. Without an
automated setup, there will be misses over time.
>
> Jay, your patches fail at least one test because you changed the unit outputs.
> Either we fix the tdc test or you make your changes backward compatible.
> In the future also cc kernel tc maintainers (I only saw this because
> someone pointed it to me).
> Overall the changes look fine.
Sent a patch to add a tc entry to iproute2 maintainers file.
You say the change looks fine but at least one test fails meaning
changes are requested?
next prev parent reply other threads:[~2025-09-11 20:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 1:42 [PATCH iproute2-next] tc/police: Allow 64 bit burst size Jay Vosburgh
2025-09-07 1:42 ` [PATCH 1/4 iproute2-next] lib: Update backend of print_size to accept 64 bit size Jay Vosburgh
2025-09-07 1:42 ` [PATCH 2/4 iproute2-next] tc: Add get_size64 and get_size64_and_cell Jay Vosburgh
2025-09-07 1:42 ` [PATCH 3/4 iproute2-next] tc: Expand tc_calc_xmittime, tc_calc_xmitsize to u64 Jay Vosburgh
2025-09-07 1:42 ` [PATCH 4/4 iproute2-next] tc/police: enable use of 64 bit burst parameter Jay Vosburgh
2025-09-10 3:32 ` [PATCH iproute2-next] tc/police: Allow 64 bit burst size Jamal Hadi Salim
2025-09-10 4:04 ` Jay Vosburgh
2025-09-10 4:29 ` Jamal Hadi Salim
2025-09-11 20:50 ` David Ahern [this message]
2025-09-12 4:19 ` Jay Vosburgh
2025-09-12 14:31 ` Jamal Hadi Salim
2025-09-12 15:48 ` Victor Nogueira
2025-09-15 7:51 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b7afbf-318a-49c8-9e40-bcb4b452201b@gmail.com \
--to=dsahern@gmail.com \
--cc=jay.vosburgh@canonical.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).