public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonas Jelonek <jelonek.jonas@gmail.com>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Bjørn Mork" <bjorn@mork.no>, "Paolo Abeni" <pabeni@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"David S . Miller" <davem@davemloft.net>,
	"Russell King" <linux@armlinux.org.uk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v4] net: sfp: add SMBus I2C block support
Date: Fri, 16 Jan 2026 12:16:11 +0100	[thread overview]
Message-ID: <d5c11fec-1e75-46cf-aeae-593fb6a4af09@gmail.com> (raw)
In-Reply-To: <0c181c3d-cb68-4ce4-b505-6fc9d10495cd@bootlin.com>

Hi Maxime,

On 09.01.26 18:03, Maxime Chevallier wrote:
> ACK, I'll gladly help with testing. This should actually be easily
> achievable with a board that has a real i2c interface connected to the
> SFP cage, as there's a i2c smbus emulation layer. The SMBus helpers will
> work with a true I2C adapter, you may have to tweak the code though.
>
> This is relevant for modules that have a built-in PHY that you can
> access, if you don't have any I can run some tests here, I have more
> than enough modules...
>
> If you don't have time at all for that, I may give this a shot at some
> point, but my time is a bit scarce right now :'(
>

I'd postpone this part if that's ok. Quite busy at the moment :(

When I come to trying to work on that, should that all be kept in
mdio-i2c.c? I'm asking because we have a downstream implementation
moving that SMbus stuff to mdio-smbus.c. This covers quite a lot right
now, C22/C45 and Rollball, but just with byte access [1]. Because that
isn't my work, I'll need to check with the original authors and adapt this
for an upstream patch, trying to add word + block access.

Kind regards,
Jonas

[1] https://github.com/openwrt/openwrt/blob/66b6791abe6f08dec2924b5d9e9e7dac93f37bc4/target/linux/realtek/patches-6.12/712-net-phy-add-an-MDIO-SMBus-library.patch

  reply	other threads:[~2026-01-16 11:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 10:13 [PATCH net-next v4] net: sfp: add SMBus I2C block support Jonas Jelonek
2026-01-09 12:13 ` Russell King (Oracle)
2026-01-09 16:21   ` Russell King (Oracle)
2026-01-09 16:46     ` Jonas Jelonek
2026-01-09 15:51 ` Maxime Chevallier
2026-01-09 16:48   ` Jonas Jelonek
2026-01-09 17:03     ` Maxime Chevallier
2026-01-16 11:16       ` Jonas Jelonek [this message]
2026-01-16 11:21         ` Russell King (Oracle)
2026-01-16 11:51           ` Bjørn Mork
2026-01-16 13:14         ` Maxime Chevallier
2026-01-16 13:15         ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d5c11fec-1e75-46cf-aeae-593fb6a4af09@gmail.com \
    --to=jelonek.jonas@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox