From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7191DC433FE for ; Fri, 25 Feb 2022 11:10:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239941AbiBYLLF (ORCPT ); Fri, 25 Feb 2022 06:11:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238967AbiBYLLD (ORCPT ); Fri, 25 Feb 2022 06:11:03 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C743197B51; Fri, 25 Feb 2022 03:10:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645787432; x=1677323432; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=Tm075Fx16DfjHBtJEGna7CmW+o40n6UD+/Aw9R+hYBk=; b=UmtdF7B3JQZRQAEe8BuC+b0vcK41zJBDXqtQv0uhJUMHQDgn2Qc4+26r Gad/4TGMr8QJJv0M3vSczPTDaOtAGsQq3JDE8+/5ZglAeaouyA0zXYvQ4 KhYVkmc9A3jK1FN5pSoYAqtZAiqGQs263feXxrCgswvtOFkdbYBvz95q4 0/ox/KIH0xeZGEOruRUz5ZQMVFhBe9kBkMnA1h3ju0tmiME6SliPXIAwb A4iEyC1h4fPJJSUQxxNCgU3LqCBl6oW+Lv2S8kHbnwyrUS6nzHQK8zrh+ PqSHFjV+fDtl8FH6FjdzUcfTQ0ymzsk6nQu29eonhWYeHJSAuHJioAZ6r g==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252672301" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="252672301" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 03:10:32 -0800 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="549223077" Received: from grossi-mobl.ger.corp.intel.com ([10.252.47.60]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 03:10:24 -0800 Date: Fri, 25 Feb 2022 13:10:22 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Ricardo Martinez cc: Netdev , linux-wireless@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, m.chetan.kumar@intel.com, chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, amir.hanania@intel.com, Andy Shevchenko , dinesh.sharma@intel.com, eliot.lee@intel.com, moises.veleta@intel.com, pierre-louis.bossart@intel.com, muralidharan.sethuraman@intel.com, Soumya.Prakash.Mishra@intel.com, sreehari.kancharla@intel.com, madhusmita.sahu@intel.com Subject: Re: [PATCH net-next v5 03/13] net: wwan: t7xx: Add core components In-Reply-To: <20220223223326.28021-4-ricardo.martinez@linux.intel.com> Message-ID: References: <20220223223326.28021-1-ricardo.martinez@linux.intel.com> <20220223223326.28021-4-ricardo.martinez@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 23 Feb 2022, Ricardo Martinez wrote: > From: Haijun Liu > > Registers the t7xx device driver with the kernel. Setup all the core > components: PCIe layer, Modem Host Cross Core Interface (MHCCIF), > modem control operations, modem state machine, and build > infrastructure. > > * PCIe layer code implements driver probe and removal. > * MHCCIF provides interrupt channels to communicate events > such as handshake, PM and port enumeration. > * Modem control implements the entry point for modem init, > reset and exit. > * The modem status monitor is a state machine used by modem control > to complete initialization and stop. It is used also to propagate > exception events reported by other components. > > Signed-off-by: Haijun Liu > Signed-off-by: Chandrashekar Devegowda > Co-developed-by: Ricardo Martinez > Signed-off-by: Ricardo Martinez > > >From a WWAN framework perspective: > Reviewed-by: Loic Poulain > --- > + /* IPs enable interrupts when ready */ > + for (i = 0; i < EXT_INT_NUM; i++) > + t7xx_pcie_mac_clear_int(t7xx_dev, i); In v4, PCIE_MAC_MSIX_MSK_SET() wrote to IMASK_HOST_MSIX_SET_GRP0_0. In v5, t7xx_pcie_mac_clear_int() writes to IMASK_HOST_MSIX_CLR_GRP0_0. t7xx_pcie_mac_set_int() would write to IMASK_HOST_MSIX_SET_GRP0_0 matching to what v4 did. So you probably want to call t7xx_pcie_mac_set_int() instead of t7xx_pcie_mac_clear_int()? -- i.