From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH net] ipv6: omit traffic class when calculating flow hash Date: Fri, 1 Jun 2018 14:25:22 +0200 Message-ID: References: <20180601112948.93BE7A0C48@unicorn.suse.cz> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Herbert , David Ahern To: Michal Kubecek , "David S. Miller" Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:37174 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbeFAMZZ (ORCPT ); Fri, 1 Jun 2018 08:25:25 -0400 Received: by mail-wm0-f65.google.com with SMTP id l1-v6so2329138wmb.2 for ; Fri, 01 Jun 2018 05:25:24 -0700 (PDT) In-Reply-To: <20180601112948.93BE7A0C48@unicorn.suse.cz> Content-Language: fr Sender: netdev-owner@vger.kernel.org List-ID: Le 01/06/2018 à 12:34, Michal Kubecek a écrit : > Some of the code paths calculating flow hash for IPv6 use flowlabel member > of struct flowi6 which, despite its name, encodes both flow label and > traffic class. If traffic class changes within a TCP connection (as e.g. > ssh does), ECMP route can switch between path. It's also incosistent with nit: s/incosistent/inconsistent > other code paths where ip6_flowlabel() (returning only flow label) is used > to feed the key. > > Use only flow label everywhere, including one place where hash key is set > using ip6_flowinfo(). > > Fixes: 51ebd3181572 ("ipv6: add support of equal cost multipath (ECMP)") > Fixes: f70ea018da06 ("net: Add functions to get skb->hash based on flow structures") > Signed-off-by: Michal Kubecek Acked-by: Nicolas Dichtel