From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH, net-next] qcom-emag: hide ACPI specific functions Date: Fri, 25 May 2018 19:22:09 -0500 Message-ID: References: <20180525213714.2120604-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Hemanth Puranik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arnd Bergmann , "David S. Miller" Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:42332 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968411AbeEZAWM (ORCPT ); Fri, 25 May 2018 20:22:12 -0400 In-Reply-To: <20180525213714.2120604-1-arnd@arndb.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/25/18 4:37 PM, Arnd Bergmann wrote: > +#ifdef CONFIG_ACPI > static int emac_sgmii_irq_clear(struct emac_adapter *adpt, u8 irq_bits) > { > struct emac_sgmii *phy = &adpt->phy; > @@ -288,6 +289,7 @@ static struct sgmii_ops qdf2400_ops = { > .link_change = emac_sgmii_common_link_change, > .reset = emac_sgmii_common_reset, > }; > +#endif This seems wrong. The SGMII interrupt handler should still be viable on a device-tree system. There is a DT compatibility entry for the qdf2432. Looks like that most recent patch on net-next broke DT support, when it removed these lines: - phy->open = emac_sgmii_open; - phy->close = emac_sgmii_close; - phy->link_up = emac_sgmii_link_up; - phy->link_down = emac_sgmii_link_down; I'll take it look at it next week when I'm back in the office. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.