From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Dichtel Subject: Re: [PATCH iproute2] ip: IFLA_NEW_NETNSID/IFLA_NEW_IFINDEX support Date: Thu, 31 May 2018 17:51:16 +0200 Message-ID: References: <20180531142848.377-1-nicolas.dichtel@6wind.com> <20180531114615.3f10766f@shemminger-XPS-13-9360> Reply-To: nicolas.dichtel@6wind.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org To: Stephen Hemminger Return-path: Received: from mail-wr0-f176.google.com ([209.85.128.176]:45859 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755456AbeEaPvT (ORCPT ); Thu, 31 May 2018 11:51:19 -0400 Received: by mail-wr0-f176.google.com with SMTP id o12-v6so2431934wrm.12 for ; Thu, 31 May 2018 08:51:19 -0700 (PDT) In-Reply-To: <20180531114615.3f10766f@shemminger-XPS-13-9360> Content-Language: fr Sender: netdev-owner@vger.kernel.org List-ID: Le 31/05/2018 à 17:46, Stephen Hemminger a écrit : > On Thu, 31 May 2018 16:28:48 +0200 [snip] > This makes sense. All of linkinfo that is present should be displayed. > > Both netns and ifindex are really unsigned values. Use __u32 and print_uint. Ok. > Also why not convert numeric values to names? The only case where the ifname can change is when a netns is deleted and the interface is put back in init_net. But at this stage, we don't know the new name. For the nsid, you're right, it will be better to display the netns name. If you agree, I will do this in a following patch, thus all places using nsid can be converted at the same time. Regards, Nicolas