From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jia-Ju Bai Subject: Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload Date: Wed, 11 Apr 2018 15:17:10 +0800 Message-ID: References: <1523410174-1553-1-git-send-email-baijiaju1990@gmail.com> <20180411064135.GA28354@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, samuel@sortiz.org, netdev@vger.kernel.org, johan@kernel.org, linux-kernel@vger.kernel.org, arvind.yadav.cs@gmail.com, davem@davemloft.net To: Greg KH Return-path: In-Reply-To: <20180411064135.GA28354@kroah.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org On 2018/4/11 14:41, Greg KH wrote: > On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: >> stir421x_fw_upload() is never called in atomic context. >> >> The call chain ending up at stir421x_fw_upload() is: >> [1] stir421x_fw_upload() <- stir421x_patch_device() <- irda_usb_probe() >> >> irda_usb_probe() is set as ".probe" in struct usb_driver. >> This function is not called in atomic context. >> >> Despite never getting called from atomic context, stir421x_fw_upload() >> calls mdelay() to busily wait. >> This is not necessary and can be replaced with usleep_range() to >> avoid busy waiting. >> >> This is found by a static analysis tool named DCNS written by myself. >> And I also manually check it. >> >> Signed-off-by: Jia-Ju Bai >> --- >> drivers/staging/irda/drivers/irda-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Please, at the very least, work off of Linus's tree. There is no > drivers/staging/irda/ anymore :) > Okay, sorry. Could you please recommend me a right tree or its git address? Best wishes, Jia-Ju Bai