From: David Ahern <dsahern@gmail.com>
To: Mike Manning <mmanning@vyatta.att-mail.com>, netdev@vger.kernel.org
Cc: Duncan Eastoe <deastoe@vyatta.att-mail.com>
Subject: Re: [PATCH net-next v4 5/9] net: fix raw socket lookup device bind matching with VRFs
Date: Tue, 6 Nov 2018 11:08:33 -0700 [thread overview]
Message-ID: <d66a8ab0-a16d-c9c1-00ad-8442bd9c6de0@gmail.com> (raw)
In-Reply-To: <20181102191020.14170-6-mmanning@vyatta.att-mail.com>
since you are re-sending, a couple of nits ...
On 11/2/18 1:10 PM, Mike Manning wrote:
> diff --git a/include/net/raw.h b/include/net/raw.h
> index 20ebf0b3dfa8..6ed2ae5b4a80 100644
> --- a/include/net/raw.h
> +++ b/include/net/raw.h
> @@ -18,6 +18,7 @@
> #define _RAW_H
>
>
> +#include <net/inet_sock.h>
Replace one of the extra newlines after '#define _RAW_H' with this new one.
> #include <net/protocol.h>
> #include <linux/icmp.h>
>
> @@ -75,4 +76,15 @@ static inline struct raw_sock *raw_sk(const struct sock *sk)
> return (struct raw_sock *)sk;
> }
>
> +static inline bool raw_sk_bound_dev_eq(struct net *net, int bound_dev_if,
> + int dif, int sdif)
> +{
> +#if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV)
> + return inet_bound_dev_eq(net->ipv4.sysctl_raw_l3mdev_accept,
> + bound_dev_if, dif, sdif);
!!net->ipv4.sysctl_raw_l3mdev_accept
next prev parent reply other threads:[~2018-11-07 3:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:10 [PATCH net-next v4 0/9] vrf: allow simultaneous service instances in default and other VRFs Mike Manning
2018-11-02 19:10 ` [PATCH net-next v4 1/9] net: allow binding socket in a VRF when there's an unbound socket Mike Manning
2018-11-06 17:52 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 2/9] net: ensure unbound stream socket to be chosen when not in a VRF Mike Manning
2018-11-06 17:55 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 3/9] net: ensure unbound datagram " Mike Manning
2018-11-06 17:59 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 4/9] net: provide a sysctl raw_l3mdev_accept for raw socket lookup with VRFs Mike Manning
2018-11-06 18:05 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 5/9] net: fix raw socket lookup device bind matching " Mike Manning
2018-11-06 18:08 ` David Ahern [this message]
2018-11-02 19:10 ` [PATCH net-next v4 6/9] vrf: mark skb for multicast or link-local as enslaved to VRF Mike Manning
2018-11-06 18:13 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 7/9] ipv6: allow ping to link-local address in VRF Mike Manning
2018-11-06 18:14 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 8/9] ipv6: handling of multicast packets received " Mike Manning
2018-11-06 18:24 ` David Ahern
2018-11-02 19:10 ` [PATCH net-next v4 9/9] ipv6: do not drop vrf udp multicast packets Mike Manning
2018-11-06 18:24 ` David Ahern
2018-11-04 15:52 ` [PATCH net-next v4 0/9] vrf: allow simultaneous service instances in default and other VRFs David Ahern
2018-11-04 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66a8ab0-a16d-c9c1-00ad-8442bd9c6de0@gmail.com \
--to=dsahern@gmail.com \
--cc=deastoe@vyatta.att-mail.com \
--cc=mmanning@vyatta.att-mail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).