From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next v4 5/9] net: fix raw socket lookup device bind matching with VRFs Date: Tue, 6 Nov 2018 11:08:33 -0700 Message-ID: References: <20181102191020.14170-1-mmanning@vyatta.att-mail.com> <20181102191020.14170-6-mmanning@vyatta.att-mail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Duncan Eastoe To: Mike Manning , netdev@vger.kernel.org Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:38549 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730164AbeKGDfB (ORCPT ); Tue, 6 Nov 2018 22:35:01 -0500 Received: by mail-pl1-f195.google.com with SMTP id p4-v6so4181542plo.5 for ; Tue, 06 Nov 2018 10:08:36 -0800 (PST) In-Reply-To: <20181102191020.14170-6-mmanning@vyatta.att-mail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: since you are re-sending, a couple of nits ... On 11/2/18 1:10 PM, Mike Manning wrote: > diff --git a/include/net/raw.h b/include/net/raw.h > index 20ebf0b3dfa8..6ed2ae5b4a80 100644 > --- a/include/net/raw.h > +++ b/include/net/raw.h > @@ -18,6 +18,7 @@ > #define _RAW_H > > > +#include Replace one of the extra newlines after '#define _RAW_H' with this new one. > #include > #include > > @@ -75,4 +76,15 @@ static inline struct raw_sock *raw_sk(const struct sock *sk) > return (struct raw_sock *)sk; > } > > +static inline bool raw_sk_bound_dev_eq(struct net *net, int bound_dev_if, > + int dif, int sdif) > +{ > +#if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) > + return inet_bound_dev_eq(net->ipv4.sysctl_raw_l3mdev_accept, > + bound_dev_if, dif, sdif); !!net->ipv4.sysctl_raw_l3mdev_accept