From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02089C282C8 for ; Mon, 28 Jan 2019 19:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6BB920989 for ; Mon, 28 Jan 2019 19:02:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n9pL4bgV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727548AbfA1TC6 (ORCPT ); Mon, 28 Jan 2019 14:02:58 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:44830 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727259AbfA1TC4 (ORCPT ); Mon, 28 Jan 2019 14:02:56 -0500 Received: by mail-wr1-f65.google.com with SMTP id z5so19288587wrt.11 for ; Mon, 28 Jan 2019 11:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1HZqnpXs0uNNJqmVS02Uw+aH6+UpArA9v3/cmfKRakg=; b=n9pL4bgV3exz+xSqWVtdezOp1+u7+pIrLq9s7TfKTXLy90oghtDJPJ9RRhMll+CF20 HllOWbheWiODtn1fjHlkUgagKLYOx405+Dw8E7TeCo+7sTcAVGmEVBSe8prHg4cCjMTg 3NzeMTOoE9L2yAy1qGvik/6LziBylPZVys5HBApUfR+cZZS0yAl557LWATIp1dnb3vCJ vUBSZBgfGIjMxpqwywayHUt33R5j6cElG66r06dtUAgKr7kAX9Ry+HM/dnqcmK5bqLrx g55pC1L8k3f5d/1DlJf8oSgDkdoZIUBAUnzp9uAQCsufXru1IQ8+xoRmUnmokh+UD5pU YVtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1HZqnpXs0uNNJqmVS02Uw+aH6+UpArA9v3/cmfKRakg=; b=HdoKWk2CZ1mn1rsfa6vHr/2YO9j9E1VYetAP1YlSU25622PK0vrsAUgLWvrIIY3WRN W1YqnGIXvFnQGW++PBvclacahXOTndyOPaObOHCc57q5rEwczzsSAeUxfVzkakCf22E9 9AuaQZ7EoZpRquR5eW27KIxpOzk+MR9ifKtLgItMeKshEhajwKv/J6+Zyzs8r8UUEXvp GKhhP4UB3JZSXCT1IIWbMYKMKGzeMbm4LL2eenEFiZOmPg2FXILJkJG/w06hH7VSnf9R 3NZUNkiYZUX1B/+ERl00tKP8Zo1wzlDAM+NRZ/m3C6zd3DwgiZyViLNjuWDDm/+DvgUB eAxQ== X-Gm-Message-State: AJcUuke7l+JKmdaltk532D6RDZBgi+NNbIjRJAM7Q/It3pEkC2wqjMHN DSPfrNGNQDGzjh/GACTik8hIhT1n X-Google-Smtp-Source: ALg8bN60vEjNy4FBecOvC7XAL1zugAntoqlyJ2/gY6LSos6mjfJeL/BcKonsebCtjElhWUh3MJVJkg== X-Received: by 2002:a5d:538a:: with SMTP id d10mr22255606wrv.202.1548702174273; Mon, 28 Jan 2019 11:02:54 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:2c9c:e1a3:b321:9449? (p200300EA8BF1E2002C9CE1A3B3219449.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:2c9c:e1a3:b321:9449]) by smtp.googlemail.com with ESMTPSA id s8sm127792445wrn.44.2019.01.28.11.02.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 11:02:53 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <20190125055919.GB27062@torres.zugschlus.de> <6ae02156-8903-70fd-675f-a5aee9c452b4@gmail.com> <20190125120210.GC27062@torres.zugschlus.de> <548c1682-ad7c-3a0a-b2ea-2207f328b070@gmail.com> <20190126135640.GD27062@torres.zugschlus.de> <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com> <20190126170752.GE27062@torres.zugschlus.de> <6ecafe07-3278-a9c4-d76d-971c0df26ce8@gmail.com> <20190127205555.GF27062@torres.zugschlus.de> <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com> <20190128073010.GG27062@torres.zugschlus.de> From: Heiner Kallweit Message-ID: Date: Mon, 28 Jan 2019 20:02:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190128073010.GG27062@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 28.01.2019 08:30, Marc Haber wrote: > On Sun, Jan 27, 2019 at 10:09:51PM +0100, Heiner Kallweit wrote: >> Yes. All you have to do after each "git bisect good/bad" is build again, >> test, and make current build as good or bad. > > Will report back if I get any results. When I bisected last time, I > ended up with a kernel that didn't even boot, but with 5 steps this is > probably manageable. Will take most of the week though. > > Greetings > Marc > One more test .. Can you provide the output of the following under 4.18 and under 4.19? It may not apply cleanly, but you get the idea. The message is written when suspending. diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 3e650bd9e..3a8b4b1b1 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6927,6 +6927,8 @@ static int rtl8169_suspend(struct device *device) rtl8169_net_suspend(dev); clk_disable_unprepare(tp->clk); + pr_info("may wakeup? %d\n", device_may_wakeup(device)); + return 0; } -- 2.20.1