From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Nemanov, Michael" <michael.nemanov@ti.com>,
Kalle Valo <kvalo@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH v3 03/17] wifi: cc33xx: Add sdio.c, io.c, io.h
Date: Thu, 8 Aug 2024 09:45:15 +0200 [thread overview]
Message-ID: <d682bc48-5ba5-4031-a0e6-ad1beedd1057@kernel.org> (raw)
In-Reply-To: <68d0852a-2390-4fe4-be16-3f691e99bd86@ti.com>
On 07/08/2024 16:55, Nemanov, Michael wrote:
> On 8/7/2024 10:12 AM, Krzysztof Kozlowski wrote:
>
>
>
>>> +static const struct of_device_id cc33xx_sdio_of_match_table[] = {
>>> + { .compatible = "ti,cc3300", .data = &cc33xx_data },
>>> + { .compatible = "ti,cc3301", .data = &cc33xx_data },
>>> + { .compatible = "ti,cc3350", .data = &cc33xx_data },
>>> + { .compatible = "ti,cc3351", .data = &cc33xx_data },
>>> + { }
>>> +};
>>
>>
>> Eh? What happened here? So devices are compatibles thus make them
>> compatible in the bindings.
>>
>
> I thought this is the right way to do it (originally taken from [1]).
> How can I solve it via DT bindings?
It's all over the bindings (also example-schema). Use fallback and oneOf.
>
>>
>>> +
>>> +module_param(dump, bool, 0600);
>>> +MODULE_PARM_DESC(dump, "Enable sdio read/write dumps.");
>>
>> This should be rather debug interface, not module param.
>>
>
> Meaning debugFS?
Yes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-08 7:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 17:00 [PATCH v3 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 01/17] wifi: cc33xx: Add cc33xx.h, cc33xx_i.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 02/17] wifi: cc33xx: Add debug.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 03/17] wifi: cc33xx: Add sdio.c, io.c, io.h Michael Nemanov
2024-08-07 7:12 ` Krzysztof Kozlowski
2024-08-07 14:55 ` Nemanov, Michael
2024-08-08 7:45 ` Krzysztof Kozlowski [this message]
2024-08-06 17:00 ` [PATCH v3 04/17] wifi: cc33xx: Add cmd.c, cmd.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 05/17] wifi: cc33xx: Add acx.c, acx.h Michael Nemanov
2024-08-07 7:15 ` Krzysztof Kozlowski
2024-08-07 16:09 ` Nemanov, Michael
2024-08-06 17:00 ` [PATCH v3 06/17] wifi: cc33xx: Add event.c, event.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 07/17] wifi: cc33xx: Add boot.c, boot.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 08/17] wifi: cc33xx: Add main.c Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 09/17] wifi: cc33xx: Add rx.c, rx.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 10/17] wifi: cc33xx: Add tx.c, tx.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 11/17] wifi: cc33xx: Add init.c, init.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 12/17] wifi: cc33xx: Add scan.c, scan.h Michael Nemanov
2024-08-09 16:03 ` Simon Horman
2024-10-28 16:26 ` Nemanov, Michael
2024-11-02 12:00 ` Simon Horman
2024-11-03 13:09 ` Nemanov, Michael
2024-11-06 10:20 ` Simon Horman
2024-08-06 17:00 ` [PATCH v3 13/17] wifi: cc33xx: Add conf.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 14/17] wifi: cc33xx: Add ps.c, ps.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 15/17] wifi: cc33xx: Add testmode.c, testmode.h Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 16/17] wifi: cc33xx: Add Kconfig, Makefile Michael Nemanov
2024-08-06 17:00 ` [PATCH v3 17/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml Michael Nemanov
2024-08-07 7:06 ` Krzysztof Kozlowski
2024-08-07 15:51 ` Nemanov, Michael
2024-08-08 7:45 ` Krzysztof Kozlowski
2024-08-07 7:06 ` Krzysztof Kozlowski
2024-08-07 15:53 ` Nemanov, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d682bc48-5ba5-4031-a0e6-ad1beedd1057@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michael.nemanov@ti.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sabeeh-khan@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).