From: Cosmin Ratiu <cratiu@nvidia.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "pabeni@redhat.com" <pabeni@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"sd@queasysnail.net" <sd@queasysnail.net>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net v3 0/3] macsec: Add support for VLAN filtering in offload mode
Date: Mon, 9 Mar 2026 16:19:20 +0000 [thread overview]
Message-ID: <d68d087152e11b2aa9948f84339a5e164a666d5f.camel@nvidia.com> (raw)
In-Reply-To: <20260306115353.28f322e0@kernel.org>
On Fri, 2026-03-06 at 11:53 -0800, Jakub Kicinski wrote:
> On Fri, 6 Mar 2026 17:10:01 +0200 Cosmin Ratiu wrote:
> > This short series adds support for VLANs in macsec devices when
> > offload
> > mode is enabled. This allows VLAN netdevs on top of macsec netdevs
> > to
> > function, which accidentally used to be the case in the past, but
> > was
> > broken. This series adds back proper support.
> >
> > netdevsim was extended to support VLANs and there's also a selftest
> > for
> > the new functionality.
>
> I think it's triggering the warning you added, in most of the tests:
>
> [ 20.973710][ T194] WARNING: drivers/net/netdevsim/netdev.c:1234
> at nsim_destroy+0x128/0x7b0 [netdevsim], CPU#0: peer.sh/194
Right, it seems the fuzzing test adds a bunch of VLANs then destroys
the netsim devs. It doesn't make sense to have those warnings anyway,
it's ok to not clean up the VLAN filters from a device before
destroying it, they're not a resource, they're a setting. I'll remove
the warnings in the next version.
Cosmin.
next prev parent reply other threads:[~2026-03-09 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 15:10 [PATCH net v3 0/3] macsec: Add support for VLAN filtering in offload mode Cosmin Ratiu
2026-03-06 15:10 ` [PATCH net v3 1/3] nsim: Add support for VLAN filters Cosmin Ratiu
2026-03-06 15:10 ` [PATCH net v3 2/3] selftests: Add macsec offload VLAN tests Cosmin Ratiu
2026-03-06 15:10 ` [PATCH net v3 3/3] macsec: Support VLAN-filtering lower devices Cosmin Ratiu
2026-03-06 19:53 ` [PATCH net v3 0/3] macsec: Add support for VLAN filtering in offload mode Jakub Kicinski
2026-03-06 19:54 ` Jakub Kicinski
2026-03-09 16:23 ` Cosmin Ratiu
2026-03-09 21:21 ` Jakub Kicinski
2026-03-09 16:19 ` Cosmin Ratiu [this message]
2026-03-09 16:43 ` Sabrina Dubroca
2026-03-07 18:59 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68d087152e11b2aa9948f84339a5e164a666d5f.camel@nvidia.com \
--to=cratiu@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox