From: Daniel Borkmann <daniel@iogearbox.net>
To: Josef Bacik <josef@toxicpanda.com>,
netdev@vger.kernel.org, mhiramat@kernel.org, ast@kernel.org,
darrick.wong@oracle.com, linux-kernel@vger.kernel.org
Cc: Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] trace: reenable preemption if we modify the ip
Date: Sun, 17 Dec 2017 20:49:25 +0100 [thread overview]
Message-ID: <d6b68cc7-edb0-6d30-81a5-7f4e33d4e3bf@iogearbox.net> (raw)
In-Reply-To: <1513392177-10298-1-git-send-email-josef@toxicpanda.com>
On 12/16/2017 03:42 AM, Josef Bacik wrote:
> From: Josef Bacik <jbacik@fb.com>
>
> Things got moved around between the original bpf_override_return patches
> and the final version, and now the ftrace kprobe dispatcher assumes if
> you modified the ip that you also enabled preemption. Make a comment of
> this and enable preemption, this fixes the lockdep splat that happened
> when using this feature.
>
> Signed-off-by: Josef Bacik <jbacik@fb.com>
Applied to bpf-next with Fixes tag, thanks Josef.
next prev parent reply other threads:[~2017-12-17 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 2:42 [PATCH] trace: reenable preemption if we modify the ip Josef Bacik
2017-12-17 19:49 ` Daniel Borkmann [this message]
2017-12-18 7:29 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b68cc7-edb0-6d30-81a5-7f4e33d4e3bf@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=jbacik@fb.com \
--cc=josef@toxicpanda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox