From: Yevgeny Kliteynik <kliteyn@nvidia.com>
To: Dawei Feng <dawei.feng@seu.edu.cn>, saeedm@nvidia.com, tariqt@nvidia.com
Cc: leon@kernel.org, mbloch@nvidia.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, vdogaru@nvidia.com, horms@kernel.org,
kees@kernel.org, stable@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
jianhao.xu@seu.edu.cn, zilin@seu.edu.cn
Subject: Re: [PATCH net] net/mlx5: HWS, fix matcher leak on resize target setup failure
Date: Wed, 1 Jul 2026 01:47:47 +0300 [thread overview]
Message-ID: <d6c67c8b-acbb-46fe-9f9c-b32232b00778@nvidia.com> (raw)
In-Reply-To: <20260629064049.3852759-1-dawei.feng@seu.edu.cn>
On 29-Jun-26 09:40, Dawei Feng wrote:
> hws_bwc_matcher_move() allocates a replacement matcher before setting it
> as the resize target. If mlx5hws_matcher_resize_set_target() fails, the
> replacement matcher is not attached anywhere and is leaked.
>
> Fix the leak by destroying the replacement matcher before returning from
> the resize-target failure path.
>
> The bug was first flagged by an experimental analysis tool we are
> developing for kernel memory-management bugs while analyzing
> v6.13-rc1. The tool is still under development and is not yet publicly
> available. Manual inspection confirms that the bug is still
> present in v7.1.1.
>
> An x86_64 allyesconfig build showed no new warnings. As we do not have a
> mlx5 HWS-capable device to test with, no runtime testing was able to be
> performed.
>
> Fixes: 2111bb970c78 ("net/mlx5: HWS, added backward-compatible API handling")
> Cc: stable@vger.kernel.org
> Signed-off-by: Dawei Feng <dawei.feng@seu.edu.cn>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> index eae02bc74221..3bcf412a08c4 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c
> @@ -205,6 +205,7 @@ static int hws_bwc_matcher_move(struct mlx5hws_bwc_matcher *bwc_matcher)
> ret = mlx5hws_matcher_resize_set_target(old_matcher, new_matcher);
> if (ret) {
> mlx5hws_err(ctx, "Rehash error: failed setting resize target\n");
> + mlx5hws_matcher_destroy(new_matcher);
> return ret;
> }
>
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
next prev parent reply other threads:[~2026-06-30 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 6:40 [PATCH net] net/mlx5: HWS, fix matcher leak on resize target setup failure Dawei Feng
2026-06-30 22:47 ` Yevgeny Kliteynik [this message]
2026-07-01 14:38 ` Paolo Abeni
2026-07-01 19:02 ` Tariq Toukan
2026-07-02 7:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c67c8b-acbb-46fe-9f9c-b32232b00778@nvidia.com \
--to=kliteyn@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dawei.feng@seu.edu.cn \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@nvidia.com \
--cc=vdogaru@nvidia.com \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox