From: Johannes Berg <johannes@sipsolutions.net>
To: Marek Vasut <marex@denx.de>, linux-wireless@vger.kernel.org
Cc: Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Angus Ainslie <angus@akkea.ca>, Jakub Kicinski <kuba@kernel.org>,
Kalle Valo <kvalo@kernel.org>,
Martin Fuzzey <martin.fuzzey@flowbird.group>,
Martin Kepplinger <martink@posteo.de>,
Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Siva Rebbagondla <siva8118@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port
Date: Fri, 04 Nov 2022 17:23:40 +0100 [thread overview]
Message-ID: <d6c8594159368034d47a169ccdd50bc65a1ad894.camel@sipsolutions.net> (raw)
In-Reply-To: <a3ef782d-9c85-d752-52b5-589d5e1f1bd5@denx.de>
On Fri, 2022-11-04 at 17:09 +0100, Marek Vasut wrote:
>
> In V2 it was suggested I deduplicate this into a separate function,
> since the test is done in multiple places. I would like to keep it
> deduplicated.
Well, it's now a lot simpler, so one might argue that it's not needed.
But anyway you're touching the hot-path of this driver, and making it an
inline still keeps it de-duplicated, so not sure why you wouldn't just
move the rsi_is_tx_eapol into the header file as static inline?
johannes
next prev parent reply other threads:[~2022-11-04 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 15:58 [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port Marek Vasut
2022-11-04 16:01 ` Johannes Berg
2022-11-04 16:09 ` Marek Vasut
2022-11-04 16:23 ` Johannes Berg [this message]
2022-11-04 16:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c8594159368034d47a169ccdd50bc65a1ad894.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=amit.karwar@redpinesignals.com \
--cc=angus@akkea.ca \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marex@denx.de \
--cc=martin.fuzzey@flowbird.group \
--cc=martink@posteo.de \
--cc=netdev@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox