From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC04C28CC0 for ; Wed, 29 May 2019 09:18:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5588A2070D for ; Wed, 29 May 2019 09:18:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="BQTKFzkB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbfE2JSF (ORCPT ); Wed, 29 May 2019 05:18:05 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50640 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbfE2JSF (ORCPT ); Wed, 29 May 2019 05:18:05 -0400 Received: by mail-wm1-f67.google.com with SMTP id f204so1102010wme.0 for ; Wed, 29 May 2019 02:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PA7o+E5TanGr16h7Oy845fcFh8G+pAiv4rWZfkX/jjI=; b=BQTKFzkBVyyJw/5nn247Cer8dg7TyVU4wv8QAOoWRl6JTMAQiw4/zk8X4vUIF1K6jx +D3zHTTJGooSSEbfuVfNF0dS0ngrIO0j4I9Pi+O2U5OaTRhGoQlbNlUcab9smZ6t5+13 8vNGft3DwvSM5GFWYLrT2a6i1Nk3ATXcEpu2sCce+v/M9QtHYMTs/HFqu4K5uamuDaHq cxRe79oMnpsUvNedfGL8IutjCEEX/lv2gTJkbJz7EYWhh253dkGn4fqBnI59KuAAPAn9 SGy5qoKkjOURTS6WssbVC/74QFhP2T4nvRTmse2nVr465749SeP4T/XxMopmtV50r9up lrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PA7o+E5TanGr16h7Oy845fcFh8G+pAiv4rWZfkX/jjI=; b=NPbFmxNrJxVj/LddBuHTyKYr2AvpZpcx1AMQFOuw02x4KqQaKovMGSii/FlJ+SqKV8 TLXr8t7wUJoUGfjrINVw14IvnNc7NugNyn1z8chIRffNs/Uko2c/t0bP7yxJ0lKrBXFf XxzaC7IlhT83EVwMyFnVgg2J60cn+NRA66SX5vFxPVoC6N6JYHGIOtjGUCmzSDJq7/JR JhimaL29Sqi2fIBkREHDTLpp4OP7dpiPd7wGffOPioT6lCLGMfsNah9dY+7NCjXoJnOT UeJTfFvMz37flp3bem4qBRXE6EiFKempkYwFnWP0fgEj2gMT3VVlRBfXqhISIoBPkTzq rUeQ== X-Gm-Message-State: APjAAAXpdh6K4eJSTVA7rfh3URF7dE/k9PQ7638P1mvgMMz76oo/20DC RIulk5XcPIBHOBardZKHWxV39w== X-Google-Smtp-Source: APXvYqx3K5WS7jTcKEBdb+W1wgXo5qW2Emzn407GM/gllJHuwwpXz0Vlm0xarau4UMZnbVwPBod/aA== X-Received: by 2002:a1c:4054:: with SMTP id n81mr4716322wma.78.1559121482805; Wed, 29 May 2019 02:18:02 -0700 (PDT) Received: from [192.168.1.2] ([194.53.187.60]) by smtp.gmail.com with ESMTPSA id y2sm4553438wra.58.2019.05.29.02.18.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 02:18:01 -0700 (PDT) Subject: Re: [PATCH bpf-next v3 2/3] libbpf: add bpf_object__load_xattr() API function to pass log_level To: Alexei Starovoitov Cc: Daniel Borkmann , bpf , Network Development , oss-drivers@netronome.com, Yonghong Song , Andrii Nakryiko References: <20190524103648.15669-1-quentin.monnet@netronome.com> <20190524103648.15669-3-quentin.monnet@netronome.com> From: Quentin Monnet Message-ID: Date: Wed, 29 May 2019 10:18:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-05-28 17:35 UTC-0700 ~ Alexei Starovoitov > On Fri, May 24, 2019 at 3:36 AM Quentin Monnet > wrote: >> >> libbpf was recently made aware of the log_level attribute for programs, >> used to specify the level of information expected to be dumped by the >> verifier. Function bpf_prog_load_xattr() got support for this log_level >> parameter. >> >> But some applications using libbpf rely on another function to load >> programs, bpf_object__load(), which does accept any parameter for log >> level. Create an API function based on bpf_object__load(), but accepting >> an "attr" object as a parameter. Then add a log_level field to that >> object, so that applications calling the new bpf_object__load_xattr() >> can pick the desired log level. >> >> v3: >> - Rewrite commit log. >> >> v2: >> - We are in a new cycle, bump libbpf extraversion number. >> >> Signed-off-by: Quentin Monnet >> Reviewed-by: Jakub Kicinski >> --- >> tools/lib/bpf/Makefile | 2 +- >> tools/lib/bpf/libbpf.c | 20 +++++++++++++++++--- >> tools/lib/bpf/libbpf.h | 6 ++++++ >> tools/lib/bpf/libbpf.map | 5 +++++ >> 4 files changed, 29 insertions(+), 4 deletions(-) > > This commit broke ./test_progs -s > prog_tests/bpf_verif_scale.c no longer passes log_level. > Could you please take a look? > Indeed, I forgot that bpf_load_prog_xattr() would eventually call bpf_object__load_progs() as well, where the log_level is now overwritten. Fix incoming, sorry about that. Quentin